Implement handling renames and copies #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't get this info from Git for re-names. It felt funky to say that the modes were null when the files actually have modes, we just don't know what they are. Plus, we use a null file mode to indicate that the file does not exist for created/deleted files. Co-authored-by: Michelle Tilley <[email protected]>
Co-authored-by: Michelle Tilley <[email protected]>
Co-authored-by: Michelle Tilley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #10.
This technically works, but I don't love it for a couple reasons:
similarityfield only shows up if the parser detects that the diff includes a rename or copy. We could include this in all return values and just set it tonull, but the field doesn't make sense outside of the context of a copy.binaryfield is usuallytrueorfalse, but in this case, we don't actually know if the file is binary or not, so I opted to set this tonull.null, which typically can be used to determine if a file is created or deleted, but likebinary, don't make sense in this context.One option is to return different concrete and documented types for the various kinds of diffs, but that feels like a semver-major change.
If folks have 💭s, please feel free to share!
/cc @kuychaco, @kytwb, @smashwilson, @annthurium