Change operation type of reading to regular

* Allows overriding deadline at the call level

Author: w1am

src/main/java/io/kurrent/dbclient/ReadAllOptions.java

@@ -8,7 +8,6 @@ public class ReadAllOptions extends OptionsWithPositionAndResolveLinkTosBase<Rea
     private long maxCount;
 
     private ReadAllOptions() {
-        super(OperationKind.Streaming);
         this.direction = Direction.Forwards;
         this.maxCount = Long.MAX_VALUE;
     }

src/main/java/io/kurrent/dbclient/ReadStreamOptions.java

@@ -8,7 +8,6 @@ public class ReadStreamOptions extends OptionsWithStartRevisionAndResolveLinkTos
     private long maxCount;
 
     private ReadStreamOptions() {
-        super(OperationKind.Streaming);
         this.direction = Direction.Forwards;
         this.maxCount = Long.MAX_VALUE;
     }

src/test/java/io/kurrent/dbclient/streams/DeadlineTests.java

@@ -11,7 +11,7 @@
 
 public interface DeadlineTests extends ConnectionAware {
     @RetryingTest(10)
-     default void testDefaultDeadline() throws Throwable {
+    default void testDefaultDeadline() {
         KurrentDBClient client = getDatabase().connectWith(opts ->
                 opts.defaultDeadline(1)
                         .maxDiscoverAttempts(3));
@@ -21,11 +21,11 @@ default void testDefaultDeadline() throws Throwable {
         ExecutionException e = Assertions.assertThrows(ExecutionException.class, () -> client.appendToStream("toto", data).get());
         StatusRuntimeException status = (StatusRuntimeException) e.getCause();
 
-        Assertions.assertEquals(status.getStatus().getCode(), Status.Code.DEADLINE_EXCEEDED);
+        Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
     }
 
     @RetryingTest(3)
-    default void testOptionLevelDeadline() throws Throwable {
+    default void testOptionLevelDeadline() {
         KurrentDBClient client = getDatabase().defaultClient();
         UUID id = UUID.randomUUID();
 
@@ -34,6 +34,59 @@ default void testOptionLevelDeadline() throws Throwable {
         ExecutionException e = Assertions.assertThrows(ExecutionException.class, () -> client.appendToStream("toto", options, data).get());
         StatusRuntimeException status = (StatusRuntimeException) e.getCause();
 
-        Assertions.assertEquals(status.getStatus().getCode(), Status.Code.DEADLINE_EXCEEDED);
+        Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
+    }
+
+    @RetryingTest(3)
+    default void testReadStreamWithDefaultDeadline() {
+        KurrentDBClient client = getDatabase().connectWith(opts ->
+                opts.defaultDeadline(1)
+                        .maxDiscoverAttempts(3));
+
+        ReadStreamOptions options = ReadStreamOptions.get();
+
+        ExecutionException e = Assertions.assertThrows(ExecutionException.class, () -> client.readStream("$users", options).get());
+        StatusRuntimeException status = (StatusRuntimeException) e.getCause();
+
+        Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
+    }
+
+    @RetryingTest(3)
+    default void testReadStreamWithLevelDeadline() {
+        KurrentDBClient client = getDefaultClient();
+
+        ExecutionException e = Assertions.assertThrows(
+                ExecutionException.class,
+                () -> client.readStream("$users", ReadStreamOptions.get().deadline(1)).get()
+        );
+        StatusRuntimeException status = (StatusRuntimeException) e.getCause();
+
+        Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
+    }
+
+    @RetryingTest(3)
+    default void testReadAllWithDefaultDeadline() {
+        KurrentDBClient client = getDatabase().connectWith(opts ->
+                opts.defaultDeadline(1)
+                        .maxDiscoverAttempts(3));
+
+        ReadAllOptions options = ReadAllOptions.get();
+
+        ExecutionException e = Assertions.assertThrows(ExecutionException.class, () -> client.readAll(options).get());
+        StatusRuntimeException status = (StatusRuntimeException) e.getCause();
+
+        Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
+    }
+
+    @RetryingTest(3)
+    default void testReadAllWithLevelDeadline() {
+        KurrentDBClient client = getDefaultClient();
+
+        ReadAllOptions options = ReadAllOptions.get().deadline(1);
+
+        ExecutionException e = Assertions.assertThrows(ExecutionException.class, () -> client.readAll(options).get());
+        StatusRuntimeException status = (StatusRuntimeException) e.getCause();
+
+        Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
     }
 }