Skip to content

Commit 59a1941

Browse files
authored
Merge pull request #2815 from ehashman/swap-feature-flag
KEP-2400: Rename feature flag to NodeSwap
2 parents da16e6a + a771ea3 commit 59a1941

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

keps/sig-node/2400-node-swap/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ poses low risk to Kubernetes clusters that will not enable swap.
299299

300300
We summarize the implementation plan as following:
301301

302-
1. Add a feature gate `NodeSwapEnabled` to enable swap support.
302+
1. Add a feature gate `NodeSwap` to enable swap support.
303303
1. Leave the default value of kubelet flag `--fail-on-swap` to `true`, to avoid
304304
changing default behaviour.
305305
1. Introduce a new kubelet config parameter, `MemorySwap`, which configures how
@@ -336,7 +336,7 @@ type KubeletConfiguration struct {
336336
metav1.TypeMeta
337337
...
338338
// Configure swap memory available to container workloads.
339-
// +featureGate=NodeSwapEnabled
339+
// +featureGate=NodeSwap
340340
// +optional
341341
MemorySwap MemorySwapConfiguration
342342
}
@@ -513,7 +513,7 @@ Pick one of these and delete the rest.
513513
-->
514514

515515
- [x] Feature gate (also fill in values in `kep.yaml`)
516-
- Feature gate name: NodeSwapEnabled
516+
- Feature gate name: NodeSwap
517517
- Components depending on the feature gate: API Server, Kubelet
518518
- [x] Other
519519
- Describe the mechanism: `--fail-swap-on=false` flag for kubelet must also

keps/sig-node/2400-node-swap/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ milestone:
3636
# The following PRR answers are required at alpha release
3737
# List the feature gate name and the components for which it must be enabled
3838
feature-gates:
39-
- name: NodeSwapEnabled
39+
- name: NodeSwap
4040
components:
4141
- kube-apiserver
4242
- kubelet

0 commit comments

Comments
 (0)