-
Notifications
You must be signed in to change notification settings - Fork 4.2k
CA: build images without attestation manifests #8690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/release-note-edit |
|
/cherry-pick cluster-autoscaler-release-1.34 |
|
@jackfrancis: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8b50ffb to
d7b2a8a
Compare
|
/test pull-cluster-autoscaler-e2e-azure-master |
What type of PR is this?
What this PR does / why we need it:
From the
docker buildx builddocumentation:--provenance string Shorthand for "--attest=type=provenance"This PR sets
--provenance=falseforcluster-autoscalerdocker image builds to allow better ergonomics for including architecture-specific images (e.g.,registry.k8s.io/autoscaling/cluster-autoscaler-amd64:v1.34.1) into a cross-arch manifest (e.g.,registry.k8s.io/autoscaling/cluster-autoscaler:v1.34.1).Otherwise we will include attestation manifests data in the resultant image build, and run into errors like this one:
Credit to @cpuguy83
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: