Skip to content

Allow defaulted keys #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

Allow defaulted keys #177

merged 1 commit into from
Oct 21, 2020

Conversation

@apelisse
Copy link
Contributor

@apelisse apelisse commented Oct 19, 2020

This is mostly a revival of #83 from @jennybuckley

I've rebased it on master, which required a few changes. I've also decided to incorporate a couple of changes:

  1. Allow validation of missing default-able associative keys rather than have a "unvalidated" parsing
  2. Associate defaults to fields rather than strictly to associative lists (more general)

The tests that Jenny wrote are still passing, which I think is a good sign.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2020
@jpbetz
Copy link
Contributor

jpbetz commented Oct 21, 2020

The implementation fell out nicely on this one.

I don't see any problems with this.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8e408d7 into kubernetes-sigs:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@kwiesmueller kwiesmueller Awaiting requested review from kwiesmueller

@jennybuckley jennybuckley Awaiting requested review from jennybuckley

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@jpbetz jpbetz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apelisse @k8s-ci-robot @jpbetz