fix report message

sivchari · sivchari · commit 79868df79297 · 2025-07-10T19:24:22.000+09:00
Signed-off-by: sivchari &lt;shibuuuu5@gmail.com&gt;
diff --git a/pkg/analysis/ssatags/analyzer.go b/pkg/analysis/ssatags/analyzer.go
@@ -89,7 +89,7 @@ func (a *analyzer) checkField(pass *analysis.Pass, field *ast.Field, markersAcce
 		for _, marker := range listTypeMarkers {
 			pass.Report(analysis.Diagnostic{
 				Pos:     field.Pos(),
-				Message: fmt.Sprintf("%s is a byte array, which is not supported by Server-Side Apply. Remove the listType marker", utils.FieldName(field)),
+				Message: fmt.Sprintf("%s is a byte array, which does not support the listType marker. Remove the listType marker", utils.FieldName(field)),
 				SuggestedFixes: []analysis.SuggestedFix{
 					{
 						Message: fmt.Sprintf("Remove listType marker from %s", utils.FieldName(field)),
diff --git a/pkg/analysis/ssatags/testdata/src/a/a.go b/pkg/analysis/ssatags/testdata/src/a/a.go
@@ -173,5 +173,5 @@ type SSATagsTestSpec struct {
 
 	// Byte array with markers - should be ignored even if markers are present
 	// +listType=atomic
-	ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which is not supported by Server-Side Apply. Remove the listType marker"
+	ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which does not support the listType marker. Remove the listType marker"
 }
diff --git a/pkg/analysis/ssatags/testdata/src/a/a.go.golden b/pkg/analysis/ssatags/testdata/src/a/a.go.golden
@@ -172,5 +172,5 @@ type SSATagsTestSpec struct {
 	ByteArrayAliased ByteArrayAlias `json:"byteArrayAliased,omitempty"`
 
 	// Byte array with markers - should be ignored even if markers are present
-	ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which is not supported by Server-Side Apply. Remove the listType marker"
+	ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which does not support the listType marker. Remove the listType marker"
 }
diff --git a/pkg/analysis/ssatags/testdata/src/b/b.go b/pkg/analysis/ssatags/testdata/src/b/b.go
@@ -168,5 +168,5 @@ type SSATagsTestSpec struct {
 
 	// Byte array with markers - should be ignored even if markers are present
 	// +listType=atomic
-	ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which is not supported by Server-Side Apply. Remove the listType marker"
+	ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which does not support the listType marker. Remove the listType marker"
 }
diff --git a/pkg/analysis/ssatags/testdata/src/b/b.go.golden b/pkg/analysis/ssatags/testdata/src/b/b.go.golden
@@ -167,6 +167,6 @@ type SSATagsTestSpec struct {
 	ByteArrayAliased ByteArrayAlias `json:"byteArrayAliased,omitempty"`
 
 	// Byte array with markers - should be ignored even if markers are present
-	ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which is not supported by Server-Side Apply. Remove the listType marker"
+	ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which does not support the listType marker. Remove the listType marker"
 }
 

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ func (a analyzer) checkField(pass analysis.Pass, field *ast.Field, markersAcce`
`89`	`89`	`for _, marker := range listTypeMarkers {`
`90`	`90`	`pass.Report(analysis.Diagnostic{`
`91`	`91`	`Pos: field.Pos(),`
`92`		`- Message: fmt.Sprintf("%s is a byte array, which is not supported by Server-Side Apply. Remove the listType marker", utils.FieldName(field)),`
	`92`	`+ Message: fmt.Sprintf("%s is a byte array, which does not support the listType marker. Remove the listType marker", utils.FieldName(field)),`
`93`	`93`	`SuggestedFixes: []analysis.SuggestedFix{`
`94`	`94`	`{`
`95`	`95`	`Message: fmt.Sprintf("Remove listType marker from %s", utils.FieldName(field)),`
Original file line number	Diff line number	Diff line change
`@@ -173,5 +173,5 @@ type SSATagsTestSpec struct {`
`173`	`173`
`174`	`174`	`// Byte array with markers - should be ignored even if markers are present`
`175`	`175`	`// +listType=atomic`
`176`		- ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which is not supported by Server-Side Apply. Remove the listType marker"
	`176`	+ ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which does not support the listType marker. Remove the listType marker"
`177`	`177`	`}`
Original file line number	Diff line number	Diff line change
`@@ -172,5 +172,5 @@ type SSATagsTestSpec struct {`
`172`	`172`	ByteArrayAliased ByteArrayAlias `json:"byteArrayAliased,omitempty"`
`173`	`173`
`174`	`174`	`// Byte array with markers - should be ignored even if markers are present`
`175`		- ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which is not supported by Server-Side Apply. Remove the listType marker"
	`175`	+ ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which does not support the listType marker. Remove the listType marker"
`176`	`176`	`}`
Original file line number	Diff line number	Diff line change
`@@ -168,5 +168,5 @@ type SSATagsTestSpec struct {`
`168`	`168`
`169`	`169`	`// Byte array with markers - should be ignored even if markers are present`
`170`	`170`	`// +listType=atomic`
`171`		- ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which is not supported by Server-Side Apply. Remove the listType marker"
	`171`	+ ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which does not support the listType marker. Remove the listType marker"
`172`	`172`	`}`
Original file line number	Diff line number	Diff line change
`@@ -167,6 +167,6 @@ type SSATagsTestSpec struct {`
`167`	`167`	ByteArrayAliased ByteArrayAlias `json:"byteArrayAliased,omitempty"`
`168`	`168`
`169`	`169`	`// Byte array with markers - should be ignored even if markers are present`
`170`		- ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which is not supported by Server-Side Apply. Remove the listType marker"
	`170`	+ ByteArrayWithMarker []byte `json:"byteArrayWithMarker,omitempty"` // want "ByteArrayWithMarker is a byte array, which does not support the listType marker. Remove the listType marker"
`171`	`171`	`}`
`172`	`172`