Skip to content

Commit 5f557b5

Browse files
committed
replace Attached condition with Accepted in HTTPRoute docs
The HTTPRoute docs have several references to an "Attached" condition, however this condition does not exist for routes. Replaces these references with the appropriate "Accepted" condition. Signed-off-by: Steve Kriss <[email protected]>
1 parent d4d3bcb commit 5f557b5

File tree

4 files changed

+48
-48
lines changed

4 files changed

+48
-48
lines changed

apis/v1alpha2/httproute_types.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ type HTTPRouteRule struct {
249249
// must ensure that unknown values will not cause a crash.
250250
//
251251
// Unknown values here must result in the implementation setting the
252-
// Attached Condition for the Route to `status: False`, with a
252+
// Accepted Condition for the Route to `status: False`, with a
253253
// Reason of `UnsupportedValue`.
254254
//
255255
// +kubebuilder:validation:Enum=Exact;PathPrefix;RegularExpression
@@ -311,7 +311,7 @@ type HTTPPathMatch struct {
311311
// must ensure that unknown values will not cause a crash.
312312
//
313313
// Unknown values here must result in the implementation setting the
314-
// Attached Condition for the Route to `status: False`, with a
314+
// Accepted Condition for the Route to `status: False`, with a
315315
// Reason of `UnsupportedValue`.
316316
//
317317
// +kubebuilder:validation:Enum=Exact;RegularExpression
@@ -392,7 +392,7 @@ type HTTPHeaderMatch struct {
392392
// must ensure that unknown values will not cause a crash.
393393
//
394394
// Unknown values here must result in the implementation setting the
395-
// Attached Condition for the Route to `status: False`, with a
395+
// Accepted Condition for the Route to `status: False`, with a
396396
// Reason of `UnsupportedValue`.
397397
//
398398
// +kubebuilder:validation:Enum=Exact;RegularExpression
@@ -451,7 +451,7 @@ type HTTPQueryParamMatch struct {
451451
// must ensure that unknown values will not cause a crash.
452452
//
453453
// Unknown values here must result in the implementation setting the
454-
// Attached Condition for the Route to `status: False`, with a
454+
// Accepted Condition for the Route to `status: False`, with a
455455
// Reason of `UnsupportedValue`.
456456
//
457457
// +kubebuilder:validation:Enum=GET;HEAD;POST;PUT;DELETE;CONNECT;OPTIONS;TRACE;PATCH
@@ -558,7 +558,7 @@ type HTTPRouteFilter struct {
558558
// must ensure that unknown values will not cause a crash.
559559
//
560560
// Unknown values here must result in the implementation setting the
561-
// Attached Condition for the Route to `status: False`, with a
561+
// Accepted Condition for the Route to `status: False`, with a
562562
// Reason of `UnsupportedValue`.
563563
//
564564
// +unionDiscriminator
@@ -784,7 +784,7 @@ type HTTPPathModifier struct {
784784
// must ensure that unknown values will not cause a crash.
785785
//
786786
// Unknown values here must result in the implementation setting the
787-
// Attached Condition for the Route to `status: False`, with a
787+
// Accepted Condition for the Route to `status: False`, with a
788788
// Reason of `UnsupportedValue`.
789789
//
790790
// <gateway:experimental>
@@ -828,7 +828,7 @@ type HTTPRequestRedirectFilter struct {
828828
// must ensure that unknown values will not cause a crash.
829829
//
830830
// Unknown values here must result in the implementation setting the
831-
// Attached Condition for the Route to `status: False`, with a
831+
// Accepted Condition for the Route to `status: False`, with a
832832
// Reason of `UnsupportedValue`.
833833
//
834834
// +optional
@@ -871,7 +871,7 @@ type HTTPRequestRedirectFilter struct {
871871
// must ensure that unknown values will not cause a crash.
872872
//
873873
// Unknown values here must result in the implementation setting the
874-
// Attached Condition for the Route to `status: False`, with a
874+
// Accepted Condition for the Route to `status: False`, with a
875875
// Reason of `UnsupportedValue`.
876876
//
877877
// +optional

apis/v1beta1/httproute_types.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ type HTTPRouteRule struct {
248248
// must ensure that unknown values will not cause a crash.
249249
//
250250
// Unknown values here must result in the implementation setting the
251-
// Attached Condition for the Route to `status: False`, with a
251+
// Accepted Condition for the Route to `status: False`, with a
252252
// Reason of `UnsupportedValue`.
253253
//
254254
// +kubebuilder:validation:Enum=Exact;PathPrefix;RegularExpression
@@ -310,7 +310,7 @@ type HTTPPathMatch struct {
310310
// must ensure that unknown values will not cause a crash.
311311
//
312312
// Unknown values here must result in the implementation setting the
313-
// Attached Condition for the Route to `status: False`, with a
313+
// Accepted Condition for the Route to `status: False`, with a
314314
// Reason of `UnsupportedValue`.
315315
//
316316
// +kubebuilder:validation:Enum=Exact;RegularExpression
@@ -391,7 +391,7 @@ type HTTPHeaderMatch struct {
391391
// must ensure that unknown values will not cause a crash.
392392
//
393393
// Unknown values here must result in the implementation setting the
394-
// Attached Condition for the Route to `status: False`, with a
394+
// Accepted Condition for the Route to `status: False`, with a
395395
// Reason of `UnsupportedValue`.
396396
//
397397
// +kubebuilder:validation:Enum=Exact;RegularExpression
@@ -450,7 +450,7 @@ type HTTPQueryParamMatch struct {
450450
// must ensure that unknown values will not cause a crash.
451451
//
452452
// Unknown values here must result in the implementation setting the
453-
// Attached Condition for the Route to `status: False`, with a
453+
// Accepted Condition for the Route to `status: False`, with a
454454
// Reason of `UnsupportedValue`.
455455
//
456456
// +kubebuilder:validation:Enum=GET;HEAD;POST;PUT;DELETE;CONNECT;OPTIONS;TRACE;PATCH
@@ -557,7 +557,7 @@ type HTTPRouteFilter struct {
557557
// must ensure that unknown values will not cause a crash.
558558
//
559559
// Unknown values here must result in the implementation setting the
560-
// Attached Condition for the Route to `status: False`, with a
560+
// Accepted Condition for the Route to `status: False`, with a
561561
// Reason of `UnsupportedValue`.
562562
//
563563
// +unionDiscriminator
@@ -783,7 +783,7 @@ type HTTPPathModifier struct {
783783
// must ensure that unknown values will not cause a crash.
784784
//
785785
// Unknown values here must result in the implementation setting the
786-
// Attached Condition for the Route to `status: False`, with a
786+
// Accepted Condition for the Route to `status: False`, with a
787787
// Reason of `UnsupportedValue`.
788788
//
789789
// <gateway:experimental>
@@ -827,7 +827,7 @@ type HTTPRequestRedirectFilter struct {
827827
// must ensure that unknown values will not cause a crash.
828828
//
829829
// Unknown values here must result in the implementation setting the
830-
// Attached Condition for the Route to `status: False`, with a
830+
// Accepted Condition for the Route to `status: False`, with a
831831
// Reason of `UnsupportedValue`.
832832
//
833833
// +optional
@@ -870,7 +870,7 @@ type HTTPRequestRedirectFilter struct {
870870
// must ensure that unknown values will not cause a crash.
871871
//
872872
// Unknown values here must result in the implementation setting the
873-
// Attached Condition for the Route to `status: False`, with a
873+
// Accepted Condition for the Route to `status: False`, with a
874874
// Reason of `UnsupportedValue`.
875875
//
876876
// +optional

config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml

Lines changed: 20 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)