Remove ClusterVariable.DefinitionFrom field

Author: sbueringer

api/v1beta1/conversion.go

@@ -573,3 +573,9 @@ func Convert_v1beta1_Condition_To_v1_Condition(_ *Condition, _ *metav1.Condition
 	// NOTE: legacy (v1beta1) conditions should not be automatically converted into v1beta2 conditions.
 	return nil
 }
+
+func Convert_v1beta1_ClusterVariable_To_v1beta2_ClusterVariable(_ *ClusterVariable, _ *clusterv1.ClusterVariable, _ apimachineryconversion.Scope) error {
+	// NOTE: v1beta2 ClusterVariable does not have DefinitionFrom anymore. But it's fine to just lose this field,
+	// because it was already not possible to set it anymore with v1beta1.
+	return nil
+}

api/v1beta1/conversion_test.go

@@ -72,6 +72,7 @@ func ClusterFuzzFuncs(_ runtimeserializer.CodecFactory) []interface{} {
 	return []interface{}{
 		hubClusterStatus,
 		spokeClusterStatus,
+		spokeClusterVariable,
 	}
 }
 
@@ -102,6 +103,13 @@ func spokeClusterStatus(in *ClusterStatus, c fuzz.Continue) {
 	}
 }
 
+func spokeClusterVariable(in *ClusterVariable, c fuzz.Continue) {
+	c.FuzzNoCustom(in)
+
+	// Drop DefinitionFrom as we intentionally don't preserve it.
+	in.DefinitionFrom = ""
+}
+
 func ClusterClassFuncs(_ runtimeserializer.CodecFactory) []interface{} {
 	return []interface{}{
 		hubClusterClassStatus,