You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
-["Build Failed: failed to dial gRPC: unable to upgrade to h2c, received 404"](#build-failed-failed-to-dial-grpc-unable-to-upgrade-to-h2c-received-404)
15
17
@@ -49,7 +51,6 @@ make -C devenv tilt-up
49
51
50
52
2. Hit `space` to open the Tilt dashboard in your browser and here you can see the logs and status of every resource deployed.
51
53
52
-
53
54
## Teardown
54
55
55
56
To stop Tilt and remove all resources created by it, run:
@@ -60,6 +61,41 @@ make -C devenv tilt-down
60
61
61
62
ℹ️ Please make sure you are in the `workspaces/controller` directory when executing the command.
62
63
64
+
## Pull Request Checklist
65
+
66
+
Before raising a PR, ensure you run the following checks to maintain code quality and reliability:
67
+
68
+
1.**Linting**
69
+
```bash
70
+
make lint
71
+
```
72
+
- This runs static code analysis to ensure code style consistency
73
+
- Fix any linting errors before proceeding
74
+
75
+
2.**Unit Tests**
76
+
```bash
77
+
make test
78
+
```
79
+
- Runs all unit tests in the project
80
+
- Ensure all tests pass before submitting changes
81
+
- Consider adding new tests for any new functionality
82
+
83
+
3.**End-to-End Tests**
84
+
```bash
85
+
make test-e2e
86
+
```
87
+
- Validates the complete workflow of the application
88
+
- Requires a running Kubernetes cluster
89
+
90
+
### Best Practices
91
+
92
+
- Run tests locally before pushing changes
93
+
- Write meaningful commit messages
94
+
- Keep PRs focused and small
95
+
- Update documentation if you change functionality
96
+
- Consider adding new tests for new features
97
+
- Run all checks in sequence before final submission
98
+
63
99
## Troubleshooting
64
100
65
101
### "Build Failed: failed to dial gRPC: unable to upgrade to h2c, received 404"
0 commit comments