Fixed tests not found error in native (#5068)

Fixed tests not found error in native

Fixes #5029
Fixes #5053

Author: sksamuel

gradle.properties

@@ -34,4 +34,4 @@ android.enableJetifier=true
 # Kotest build settings
 # enabled/disable Kotlin targets, for improving local dev & CI/CD performance
 kotest_enableKotlinJs=true
-kotest_enableKotlinNative=false
+kotest_enableKotlinNative=true

kotest-framework/kotest-framework-engine/src/jvmMain/java/io/kotest/engine/errors/handleEngineError.jvm.kt

@@ -3,8 +3,13 @@
 package io.kotest.engine.errors
 
 import io.kotest.engine.EngineResult
-import kotlin.system.exitProcess
+import io.kotest.engine.extensions.MultipleExceptions
 
 actual fun handleEngineResult(result: EngineResult) {
-   exitProcess(1)
+   if (result.testFailures) {
+      error("Tests failed")
+   }
+   if (result.errors.isNotEmpty()) {
+      throw MultipleExceptions(result.errors)
+   }
 }

kotest-framework/kotest-framework-engine/src/nativeMain/kotlin/io/kotest/engine/errors/handleEngineError.native.kt

@@ -3,8 +3,13 @@
 package io.kotest.engine.errors
 
 import io.kotest.engine.EngineResult
-import kotlin.system.exitProcess
+import io.kotest.engine.extensions.MultipleExceptions
 
 actual fun handleEngineResult(result: EngineResult) {
-   exitProcess(1)
+   if (result.testFailures) {
+      error("Tests failed")
+   }
+   if (result.errors.isNotEmpty()) {
+      throw MultipleExceptions(result.errors)
+   }
 }

kotest-framework/kotest-framework-plugin-gradle/src/main/kotlin/io/kotest/framework/gradle/KotestPlugin.kt

@@ -207,21 +207,6 @@ abstract class KotestPlugin : Plugin<Project> {
                // we need to switch to TCSM format if running inside of intellij
                val listener = if (IntellijUtils.isIntellij()) "teamcity" else "console"
                existing.environment("KOTEST_FRAMEWORK_RUNTIME_NATIVE_LISTENER", listener)
-
-               // it seems the kotlin native test task empties this directory, so this currently does not do anything
-               existing.environment(
-                  "KOTEST_FRAMEWORK_RUNTIME_NATIVE_MODULE_TEST_REPORTS_DIR",
-                  moduleTestDirAbsolutePath
-               )
-
-               existing.environment(
-                  "KOTEST_FRAMEWORK_RUNTIME_NATIVE_ROOT_TEST_REPORTS_DIR",
-                  rootTestDirAbsolutePath
-               )
-
-               // this sets the target name in the environment, which is used by the xml report generator
-               // to add the target name to the test names
-               existing.environment("KOTEST_FRAMEWORK_RUNTIME_NATIVE_TARGET", targetName)
             }
 
             // the ksp plugin will create a configuration for each target that contains
@@ -230,6 +215,7 @@ abstract class KotestPlugin : Plugin<Project> {
             // do it for every different native target (there could be many!)
             wireKsp(target.project, kspConfigurationName(target))
 
+            // wire in the kmp test task into our kotest task
             target.project.tasks.getByName(KOTEST_TASK_NAME) {
                target.project.logger.info("> Configuring kotest task for $nativeTaskName")
                dependsOn(existing)

kotest-framework/kotest-framework-plugin-gradle/src/main/kotlin/io/kotest/framework/gradle/NativeExecConfiguration.kt

@@ -37,14 +37,9 @@ class NativeGenerator(private val environment: SymbolProcessorEnvironment) {
             """
 val includeArg = getenv("KOTEST_FRAMEWORK_RUNTIME_NATIVE_INCLUDE")?.toKString()
 val listenerType = getenv("KOTEST_FRAMEWORK_RUNTIME_NATIVE_LISTENER")?.toKString() ?: ""
-val moduleTestReportsDir = getenv("KOTEST_FRAMEWORK_RUNTIME_NATIVE_MODULE_TEST_REPORTS_DIR")?.toKString()
-val rootTestReportsDir = getenv("KOTEST_FRAMEWORK_RUNTIME_NATIVE_ROOT_TEST_REPORTS_DIR")?.toKString()
-val target = getenv("KOTEST_FRAMEWORK_RUNTIME_NATIVE_TARGET")?.toKString()
 
 val descriptor = includeArg?.let { DescriptorPaths.parse(it) }
 val filter = descriptor?.let { IncludeDescriptorFilter(it) }
-val moduleXmlReporter = moduleTestReportsDir?.let { JunitXmlReportTestEngineListener(it, null, target) }
-val rootXmlReporter = rootTestReportsDir?.let { JunitXmlReportTestEngineListener(it, null, target) }
 
 """.trim()
          )
@@ -53,9 +48,8 @@ val rootXmlReporter = rootTestReportsDir?.let { JunitXmlReportTestEngineListener
             """
 val launcher = TestEngineLauncher()
  .withNative()
+ .withTeamCityListener() // TCSM is always included to hook into the native test task reporting
  .addExtensions(listOfNotNull(filter))
- .withListener(moduleXmlReporter)
- .withListener(rootXmlReporter)
  .withSpecRefs(
     """.trim()
          ).addCode("\n")
@@ -76,7 +70,7 @@ val launcher = TestEngineLauncher()
       function.addCode(
          """
 val result = when (listenerType) {
-   "teamcity" -> launcher.withTeamCityListener().launch()
+   "teamcity" -> launcher.launch()
    else -> launcher.withConsoleListener().launch()
 }
 handleEngineResult(result)