fix: affinity/coschedule tekton issues

Workspace set must be identical for all the tasks.
Having strict subset of workspaces clearly does not work.

Signed-off-by: Matej Vašek <[email protected]>

Author: matejvasek

hack/allocate.sh

@@ -412,18 +412,6 @@ tekton() {
 
   $KUBECTL create clusterrolebinding "${namespace}:knative-serving-namespaced-admin" --clusterrole=knative-serving-namespaced-admin --serviceaccount="${namespace}:default"
 
-  # TEMPORARY WORKAROUND: Disable affinity assistant to prevent pod scheduling issues
-  # This is a workaround for issues where affinity assistant pod names don't match
-  # what's expected by task pods, causing them to fail scheduling.
-  # Related issues:
-  # - https://github.com/tektoncd/pipeline/issues/6740
-  # - https://github.com/tektoncd/pipeline/issues/7503
-  # TODO: Remove this workaround once the underlying Tekton issue is resolved
-  echo "${blue}- Disabling affinity assistant (temporary workaround)${reset}"
-  $KUBECTL patch configmap feature-flags -n tekton-pipelines \
-    -p '{"data":{"disable-affinity-assistant":"true", "coschedule":"disabled"}}' \
-    --type=merge
-
   echo "${green}✅ Tekton${reset}"
 }
 

pkg/pipelines/tekton/tasks.go

@@ -416,6 +416,12 @@ spec:
   workspaces:
     - name: source
       description: The workspace containing the function project
+    - name: cache
+      optional: true
+    - name: sslcertdir
+      optional: true
+    - name: dockerconfig
+      optional: true
   steps:
     - name: func-deploy
       image: "%s"
@@ -443,6 +449,12 @@ spec:
   workspaces:
     - name: source
       description: The workspace containing the function project
+    - name: cache
+      optional: true
+    - name: sslcertdir
+      optional: true
+    - name: dockerconfig
+      optional: true
   steps:
     - name: func-scaffold
       image: %s

pkg/pipelines/tekton/templates_s2i.go

@@ -53,6 +53,10 @@ spec:
       workspaces:
         - name: source
           workspace: source-workspace
+        - name: cache
+          workspace: cache-workspace
+        - name: dockerconfig
+          workspace: dockerconfig-workspace
       {{.RunAfterFetchSources}}
       {{.FuncScaffoldTaskRef}}
     - name: build
@@ -92,6 +96,10 @@ spec:
       workspaces:
         - name: source
           workspace: source-workspace
+        - name: cache
+          workspace: cache-workspace
+        - name: dockerconfig
+          workspace: dockerconfig-workspace
   workspaces:
     - description: Directory where function source is located.
       name: source-workspace