feat(web/dashboard/mycases): Add dynamic total pages calculation #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, I've added the logic to calculate the total number of pages dynamically for the "My Cases" section on the dashboard. The total number of cases is now divided by the cases per page to determine the correct number of pages to display. Fixes kleros#1285
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
|
@jaybuidl can you check the PR |
Member
Seems the dashboard page crashes: https://deploy-preview-1292--kleros-v2.netlify.app/#/dashboard/1/desc/all |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit a168713 and detected 0 issues on this pull request. View more on Code Climate. |
Contributor
|
solved by #1332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, I've added the logic to calculate the total number of pages dynamically for the "My Cases" section on the dashboard. The total number of cases is now divided by the cases per page to determine the correct number of pages to display.
Fixes #1285
PR-Codex overview
Detailed summary
totalPagesbased ontotalCasesandcasesPerPage.totalPagesprop in theDashboardcomponent to use the calculated value.