Skip to content

Commit 7e4eb1d

Browse files
committed
fix: data location set to storage to create a reference instead of a copy
1 parent e936c01 commit 7e4eb1d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

contracts/src/bridge/FastBridgeReceiverOnEthereum.sol

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ contract FastBridgeReceiverOnEthereum is SafeBridgeReceiverOnEthereum, IFastBrid
9191
}
9292

9393
function challenge(uint256 _ticketID) external payable override {
94-
Ticket memory ticket = tickets[_ticketID];
94+
Ticket storage ticket = tickets[_ticketID];
9595
require(ticket.claim.bridger != address(0), "Claim does not exist");
9696
require(block.timestamp - ticket.claim.claimedAt < challengeDuration, "Challenge period over");
9797
require(msg.value >= challengeDeposit, "Not enough challenge deposit");
@@ -113,7 +113,7 @@ contract FastBridgeReceiverOnEthereum is SafeBridgeReceiverOnEthereum, IFastBrid
113113
) external override {
114114
require(_verify(_messageHash, _ticketID, _messageData), "Invalid hash");
115115

116-
Ticket memory ticket = tickets[_ticketID];
116+
Ticket storage ticket = tickets[_ticketID];
117117
require(ticket.claim.bridger != address(0), "Claim does not exist");
118118
require(ticket.claim.claimedAt + challengeDuration < block.timestamp, "Challenge period not over");
119119
require(ticket.challenge.challenger == address(0), "Claim is challenged");
@@ -132,7 +132,7 @@ contract FastBridgeReceiverOnEthereum is SafeBridgeReceiverOnEthereum, IFastBrid
132132
require(isSentBySafeBridge(), "Access not allowed: SafeBridgeSender only.");
133133
require(_verify(_messageHash, _ticketID, _messageData), "Invalid hash");
134134

135-
Ticket memory ticket = tickets[_ticketID];
135+
Ticket storage ticket = tickets[_ticketID];
136136
require(ticket.relayed == false, "Message already relayed");
137137

138138
// Claim assessment if any
@@ -145,7 +145,7 @@ contract FastBridgeReceiverOnEthereum is SafeBridgeReceiverOnEthereum, IFastBrid
145145
}
146146

147147
function withdrawClaimDeposit(uint256 _ticketID) external override {
148-
Ticket memory ticket = tickets[_ticketID];
148+
Ticket storage ticket = tickets[_ticketID];
149149
require(ticket.relayed == true, "Message not relayed yet");
150150
require(ticket.claim.bridger != address(0), "Claim does not exist");
151151
require(ticket.claim.verified == true, "Claim not verified: deposit forfeited");
@@ -158,7 +158,7 @@ contract FastBridgeReceiverOnEthereum is SafeBridgeReceiverOnEthereum, IFastBrid
158158
}
159159

160160
function withdrawChallengeDeposit(uint256 _ticketID) external override {
161-
Ticket memory ticket = tickets[_ticketID];
161+
Ticket storage ticket = tickets[_ticketID];
162162
require(ticket.relayed == true, "Message not relayed");
163163
require(ticket.challenge.challenger != address(0), "Challenge does not exist");
164164
require(ticket.claim.verified == false, "Claim verified: deposit forfeited");
@@ -175,7 +175,7 @@ contract FastBridgeReceiverOnEthereum is SafeBridgeReceiverOnEthereum, IFastBrid
175175
// ************************************* //
176176

177177
function challengePeriod(uint256 _ticketID) public view returns (uint256 start, uint256 end) {
178-
Ticket memory ticket = tickets[_ticketID];
178+
Ticket storage ticket = tickets[_ticketID];
179179
require(ticket.claim.bridger != address(0), "Claim does not exist");
180180

181181
start = ticket.claim.claimedAt;

0 commit comments

Comments
 (0)