chore: foundry lint

Author: jaybuidl

contracts/foundry.toml

@@ -10,6 +10,9 @@ src = 'src'
 out = 'out'
 libs = ['../node_modules', 'lib']
 
+[lint]
+severity = ['high', 'medium']
+
 [rpc_endpoints]
 arbitrumSepolia = "https://sepolia-rollup.arbitrum.io/rpc"
 arbitrum = "https://arb1.arbitrum.io/rpc"

contracts/src/arbitration/university/KlerosCoreUniversity.sol

@@ -851,9 +851,9 @@ contract KlerosCoreUniversity is IArbitratorV2, UUPSProxiable, Initializable {
         sortitionModule.unlockStake(account, pnkLocked);
 
         // Compute the rewards
-        uint256 pnkReward = ((_params.pnkPenaltiesInRound / _params.coherentCount) * pnkCoherence) / ONE_BASIS_POINT;
+        uint256 pnkReward = ((_params.pnkPenaltiesInRound / _params.coherentCount) * pnkCoherence) / ONE_BASIS_POINT; /// forge-lint: disable-line(divide-before-multiply)
         round.sumPnkRewardPaid += pnkReward;
-        uint256 feeReward = ((round.totalFeesForJurors / _params.coherentCount) * feeCoherence) / ONE_BASIS_POINT;
+        uint256 feeReward = ((round.totalFeesForJurors / _params.coherentCount) * feeCoherence) / ONE_BASIS_POINT; /// forge-lint: disable-line(divide-before-multiply)
         round.sumFeeRewardPaid += feeReward;
 
         // Transfer the fee reward

contracts/src/libraries/SafeSend.sol

@@ -19,6 +19,6 @@ library SafeSend {
         if (_to.send(_value)) return;
 
         WethLike(_wethLike).deposit{value: _value}();
-        WethLike(_wethLike).transfer(_to, _value);
+        WethLike(_wethLike).transfer(_to, _value); /// forge-lint: disable-line(erc20-unchecked-transfer)
     }
 }

contracts/src/token/Faucet.sol

@@ -4,6 +4,7 @@ pragma solidity ^0.8.24;
 
 import "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 
+/// forge-lint: disable-next-item(erc20-unchecked-transfer)
 contract Faucet {
     // ************************************* //
     // *             Storage               * //

contracts/src/utils/TransactionBatcher.sol

@@ -17,6 +17,7 @@ contract TransactionBatcher {
         bytes[] memory datas
     ) public payable {
         for (uint256 i = 0; i < targets.length; i++) {
+            /// forge-lint: disable-next-line(unchecked-call)
             targets[i].call{value: values[i]}(datas[i]); // Intentionally ignoring return value.
         }
     }

contracts/test/foundry/KlerosCore_Disputes.t.sol

@@ -10,6 +10,7 @@ import "../../src/libraries/Constants.sol";
 
 /// @title KlerosCore_DisputesTest
 /// @dev Tests for KlerosCore dispute creation and management
+/// forge-lint: disable-next-item(erc20-unchecked-transfer)
 contract KlerosCore_DisputesTest is KlerosCore_TestBase {
     function test_createDispute_eth() public {
         // Create a new court and DK to test non-standard extra data

contracts/test/foundry/KlerosCore_Execution.t.sol

@@ -11,6 +11,7 @@ import "../../src/libraries/Constants.sol";
 
 /// @title KlerosCore_ExecutionTest
 /// @dev Tests for KlerosCore execution, rewards, and ruling finalization
+/// forge-lint: disable-next-item(erc20-unchecked-transfer)
 contract KlerosCore_ExecutionTest is KlerosCore_TestBase {
     function test_execute() public {
         uint256 disputeID = 0;

contracts/test/foundry/KlerosCore_Initialization.t.sol

@@ -14,8 +14,9 @@ import "../../src/libraries/Constants.sol";
 
 /// @title KlerosCore_InitializationTest
 /// @dev Tests for KlerosCore initialization and basic configuration
+/// forge-lint: disable-next-item(erc20-unchecked-transfer)
 contract KlerosCore_InitializationTest is KlerosCore_TestBase {
-    function test_initialize() public {
+    function test_initialize() public view {
         assertEq(core.owner(), msg.sender, "Wrong owner");
         assertEq(core.guardian(), guardian, "Wrong guardian");
         assertEq(address(core.pinakion()), address(pinakion), "Wrong pinakion address");
@@ -96,7 +97,6 @@ contract KlerosCore_InitializationTest is KlerosCore_TestBase {
         address newOwner = msg.sender;
         address newGuardian = vm.addr(1);
         address newStaker1 = vm.addr(2);
-        address newOther = vm.addr(9);
         address newJurorProsecutionModule = vm.addr(8);
         uint256 newMinStake = 1000;
         uint256 newAlpha = 10000;

contracts/test/foundry/KlerosCore_Staking.t.sol

@@ -10,6 +10,7 @@ import "../../src/libraries/Constants.sol";
 
 /// @title KlerosCore_StakingTest
 /// @dev Tests for KlerosCore staking mechanics and stake management
+/// forge-lint: disable-next-item(erc20-unchecked-transfer)
 contract KlerosCore_StakingTest is KlerosCore_TestBase {
     function test_setStake_increase() public {
         vm.prank(owner);

contracts/test/foundry/KlerosCore_TestBase.sol

@@ -23,6 +23,7 @@ import {IKlerosCore, KlerosCoreSnapshotProxy} from "../../src/arbitration/view/K
 
 /// @title KlerosCore_TestBase
 /// @dev Abstract base contract for KlerosCore tests containing shared setup and utilities
+/// forge-lint: disable-next-item(erc20-unchecked-transfer)
 abstract contract KlerosCore_TestBase is Test {
     event Initialized(uint64 version);
 
@@ -224,7 +225,7 @@ abstract contract KlerosCore_TestBase is Test {
         uint256 expectedAlpha,
         uint256 expectedFeeForJuror,
         uint256 expectedJurorsForJump
-    ) internal {
+    ) internal view {
         (
             uint96 courtParent,
             bool courtHiddenVotes,
@@ -243,7 +244,7 @@ abstract contract KlerosCore_TestBase is Test {
     }
 
     /// @dev Helper function to check times per period
-    function _assertTimesPerPeriod(uint96 courtId, uint256[4] memory expectedTimes) internal {
+    function _assertTimesPerPeriod(uint96 courtId, uint256[4] memory expectedTimes) internal view {
         uint256[4] memory courtTimesPerPeriod = core.getTimesPerPeriod(courtId);
         for (uint256 i = 0; i < 4; i++) {
             assertEq(courtTimesPerPeriod[i], expectedTimes[i], "Wrong times per period");