[test] Move mock tests outside context manager...

Because there is no need to do it there.

Also rewrote the inline comments.

Author: opacam

tests/recipes/recipe_lib_test.py

@@ -90,24 +90,27 @@ def test_build_arch(
                 android_ndk=self.ctx._ndk_dir
         )
         mock_glob.return_value = ["llvm"]
+
+        # Since the following mocks are dynamic,
+        # we mock it inside a Context Manager
         with mock.patch(
             f"pythonforandroid.recipes.{self.recipe_name}.sh.Command"
         ) as mock_sh_command, mock.patch(
             f"pythonforandroid.recipes.{self.recipe_name}.sh.make"
         ) as mock_make:
             self.recipe.build_arch(self.arch)
 
-            # make sure that the mocked methods are actually called
-            mock_glob.assert_called()
-            mock_ensure_dir.assert_called()
-            mock_current_directory.assert_called()
-            mock_find_executable.assert_called()
-            for command in self.sh_command_calls:
-                self.assertIn(
-                    mock.call(command),
-                    mock_sh_command.mock_calls,
-                )
-            mock_make.assert_called()
+        # make sure that the mocked methods are actually called
+        for command in self.sh_command_calls:
+            self.assertIn(
+                mock.call(command),
+                mock_sh_command.mock_calls,
+            )
+        mock_make.assert_called()
+        mock_glob.assert_called()
+        mock_ensure_dir.assert_called()
+        mock_current_directory.assert_called()
+        mock_find_executable.assert_called()
 
 
 class BaseTestForCmakeRecipe(BaseTestForMakeRecipe):
@@ -135,17 +138,20 @@ def test_build_arch(
                 android_ndk=self.ctx._ndk_dir
         )
         mock_glob.return_value = ["llvm"]
+
+        # Since the following mocks are dynamic,
+        # we mock it inside a Context Manager
         with mock.patch(
             f"pythonforandroid.recipes.{self.recipe_name}.sh.make"
         ) as mock_make, mock.patch(
             f"pythonforandroid.recipes.{self.recipe_name}.sh.cmake"
         ) as mock_cmake:
             self.recipe.build_arch(self.arch)
 
-            # make sure that the mocked methods are actually called
-            mock_glob.assert_called()
-            mock_ensure_dir.assert_called()
-            mock_current_directory.assert_called()
-            mock_find_executable.assert_called()
-            mock_cmake.assert_called()
-            mock_make.assert_called()
+        # make sure that the mocked methods are actually called
+        mock_cmake.assert_called()
+        mock_make.assert_called()
+        mock_glob.assert_called()
+        mock_ensure_dir.assert_called()
+        mock_current_directory.assert_called()
+        mock_find_executable.assert_called()