Memory: Fix review findings

Author: kullingk

doc/Memory.md

@@ -14,7 +14,7 @@ The scratch allocator preallocates a memory block which can be used in your prog
 This will be done when clearing the allocator. All allocations will be invalidated.
 
 ### Usecases
-You need to sove any kind of algorithms. For this you need to work with dynamic allocations, which will be thrown away 
+You need to save any kind of algorithms. For this you need to work with dynamic allocations, which will be thrown away
 after finishing your work.
 
 ### Examples

include/cppcore/Memory/TScratchAllocator.h

@@ -44,7 +44,7 @@ class TScratchAllocator {
 
     /// @brief  The class constructor with the pool size.
     /// @param[in]  numItems    The buffer size.
-    TScratchAllocator(size_t numItems);
+    explicit TScratchAllocator(size_t numItems);
 
     /// @brief  The class destructor.
     ~TScratchAllocator();
@@ -91,7 +91,7 @@ inline TScratchAllocator<T>::TScratchAllocator() :
 
 template<class T>
 inline TScratchAllocator<T>::TScratchAllocator(size_t numItems) :
-        mBlock(nullptr), mSize(0u), mIndex(0u) {
+        mBlock(nullptr), mSize(numItems), mIndex(0u) {
     reserve(numItems);
 }
 
@@ -121,7 +121,7 @@ void TScratchAllocator<T>::reserve(size_t size) {
 
 template<class T>
 inline void TScratchAllocator<T>::clear() {
-    delete mBlock;
+    delete [] mBlock;
     mBlock = nullptr;
     mSize = 0u;
 }

test/memory/TScratchAllocatorTest.cpp

@@ -1,28 +1,66 @@
+/*-----------------------------------------------------------------------------------------------
+The MIT License (MIT)
+
+Copyright (c) 2014-2024 Kim Kulling
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of
+this software and associated documentation files (the "Software"), to deal in
+the Software without restriction, including without limitation the rights to
+use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
+the Software, and to permit persons to whom the Software is furnished to do so,
+subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
+IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+-----------------------------------------------------------------------------------------------*/
 #include <cppcore/Memory/TScratchAllocator.h>
 
 #include <gtest/gtest.h>
 
 using namespace cppcore;
 
-class TScratchAllocatorTest : public testing::Test {};
+class TScratchAllocatorTest : public testing::Test {
+public:
+    static constexpr size_t BufferSize = 1024u;
+};
 
 TEST_F(TScratchAllocatorTest, CreateTest) {
     bool ok( true );
     try {
-        ScratchAllocator myAllocator(1024);
+        ScratchAllocator myAllocator(BufferSize);
     } catch ( ... ) {
         ok = false;
     }
     EXPECT_TRUE( ok );
 }
 
 TEST_F(TScratchAllocatorTest, AllocTest) {
-    ScratchAllocator myAllocator(1024);
+    ScratchAllocator myAllocator(BufferSize);
     char *ptr1 = myAllocator.alloc(512);
     EXPECT_NE(ptr1, nullptr);
-    EXPECT_EQ(myAllocator.capacity(), 1024);
+    EXPECT_EQ(myAllocator.capacity(), BufferSize);
     EXPECT_EQ(myAllocator.freeMem(), 512);
+    EXPECT_EQ(myAllocator.reservedMem(), 512);
 
     char *ptr2 = myAllocator.alloc(600);
     EXPECT_EQ(ptr2, nullptr);
+
+    myAllocator.clear();
+}
+
+TEST_F(TScratchAllocatorTest, ClearTest) {
+    ScratchAllocator myAllocator(BufferSize);
+    EXPECT_EQ(myAllocator.capacity(), BufferSize);
+    EXPECT_EQ(myAllocator.freeMem(), BufferSize);
+
+    myAllocator.clear();
+    EXPECT_EQ(myAllocator.capacity(), 0u);
+    EXPECT_EQ(myAllocator.freeMem(), 0u);
 }