Skip to content

Breaking down the attention API PR: part 2 #11140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2018
Merged

Breaking down the attention API PR: part 2 #11140

merged 1 commit into from
Sep 14, 2018

Conversation

@gabrieldemarmiesse
Copy link
Contributor

@gabrieldemarmiesse gabrieldemarmiesse commented Sep 14, 2018

Summary

This refactoring will allow the simplification of some code in #8296

Related Issues

PR Overview

  • This PR requires new unit tests [y/n] (make sure tests are included)
  • This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • This PR is backwards compatible [y/n]
  • This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

Dref360
Dref360 approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@Dref360 Dref360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@Dref360 Dref360 merged commit 5b62434 into keras-team:master Sep 14, 2018
@gabrieldemarmiesse gabrieldemarmiesse deleted the attention_api_2 branch November 7, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Dref360 Dref360 Dref360 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gabrieldemarmiesse @Dref360