Replace unsafe sprintf in examples

justinhj · justinhj · commit 26b33ed6cf10 · 2023-04-01T09:43:17.000-07:00
diff --git a/cpp/8puzzle.cpp b/cpp/8puzzle.cpp
@@ -337,8 +337,9 @@ bool PuzzleState::IsSameState( PuzzleState &rhs )
 
 void PuzzleState::PrintNodeInfo()
 {
-	char str[100];
-	sprintf( str, "%c %c %c\n%c %c %c\n%c %c %c\n", 
+  const int strSize = 100;
+	char str[strSize];
+	snprintf( str, strSize, "%c %c %c\n%c %c %c\n%c %c %c\n", 
 			tiles[0] + '0',
 			tiles[1] + '0',
 			tiles[2] + '0',
diff --git a/cpp/tests.cpp b/cpp/tests.cpp
@@ -97,8 +97,9 @@ bool MapSearchNode::IsSameState( MapSearchNode &rhs )
 
 void MapSearchNode::PrintNodeInfo()
 {
-	char str[100];
-	sprintf( str, "Node position : (%d,%d)\n", x,y );
+  const int strSize = 100;
+	char str[strSize];
+	snprintf( str, strSize, "Node position : (%d,%d)\n", x,y );
 
 	cout << str;
 }

Original file line number	Diff line number	Diff line change
`@@ -97,8 +97,9 @@ bool MapSearchNode::IsSameState( MapSearchNode &rhs )`
`97`	`97`
`98`	`98`	`void MapSearchNode::PrintNodeInfo()`
`99`	`99`	`{`
`100`		`- char str[100];`
`101`		`- sprintf( str, "Node position : (%d,%d)\n", x,y );`
	`100`	`+ const int strSize = 100;`
	`101`	`+ char str[strSize];`
	`102`	`+ snprintf( str, strSize, "Node position : (%d,%d)\n", x,y );`
`102`	`103`
`103`	`104`	`cout << str;`
`104`	`105`	`}`