Add test for reporting of illegal timeout durations

Author: marcphilipp

junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/TimeoutDuration.java

@@ -26,9 +26,9 @@ static TimeoutDuration from(Timeout timeout) {
 	private final TimeUnit unit;
 
 	TimeoutDuration(long value, TimeUnit unit) {
-		Preconditions.condition(value > 0, () -> "value must be greater than 0: " + value);
+		Preconditions.condition(value > 0, () -> "timeout duration must be a positive number: " + value);
 		this.value = value;
-		this.unit = Preconditions.notNull(unit, "unit must not be null");
+		this.unit = Preconditions.notNull(unit, "timeout unit must not be null");
 	}
 
 	public long getValue() {

junit-jupiter-engine/src/test/java/org/junit/jupiter/engine/extension/TimeoutExtensionTests.java

@@ -45,6 +45,7 @@
 import org.junit.jupiter.api.TestFactory;
 import org.junit.jupiter.api.Timeout;
 import org.junit.jupiter.engine.AbstractJupiterTestEngineTests;
+import org.junit.platform.commons.PreconditionViolationException;
 import org.junit.platform.testkit.engine.EngineExecutionResults;
 import org.junit.platform.testkit.engine.Events;
 import org.junit.platform.testkit.engine.Execution;
@@ -265,6 +266,17 @@ void includesClassNameIfMethodIsNotInTestClass() {
 					"$NestedClassWithOuterSetupMethodTestCase#setUp() timed out after 10 milliseconds");
 	}
 
+	@Test
+	@DisplayName("reports illegal timeout durations")
+	void reportsIllegalTimeoutDurations() {
+		EngineExecutionResults results = executeTestsForClass(IllegalTimeoutDurationTestCase.class);
+
+		Execution execution = findExecution(results.tests(), "testMethod()");
+		assertThat(execution.getTerminationInfo().getExecutionResult().getThrowable().orElseThrow()) //
+				.isInstanceOf(PreconditionViolationException.class) //
+				.hasMessage("timeout duration must be a positive number: 0");
+	}
+
 	private Execution findExecution(Events events, String displayName) {
 		return getOnlyElement(events //
 				.executions() //
@@ -465,4 +477,13 @@ void testMethod() {
 
 	}
 
+	static class IllegalTimeoutDurationTestCase {
+
+		@Test
+		@Timeout(0)
+		void testMethod() {
+		}
+
+	}
+
 }