Skip to content

Conversation

@ucarion
Copy link
Contributor

@ucarion ucarion commented Oct 16, 2020

The current implementation of Schema::validate has two problems:

  1. It does not detect validation problems in definitions, because it does not recursively validate each of them.
  2. It wrongly reports root definitions as being illegal non-root definitions.

This PR fixes both by first adding a test to the validation test suite that makes sure each schema from that test suite is considered valid. This reveals problem (2). Fixing (2) forces us to fix (1) as well.

@ucarion ucarion merged commit c571e73 into master Oct 16, 2020
@ucarion ucarion deleted the ucarion/fix-validate branch October 16, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants