fix bug when applying defaults for array items when the schema is for

all items

Author: Mathieu Rochette

src/JsonSchema/Constraints/UndefinedConstraint.php

@@ -252,7 +252,11 @@ protected function applyDefaultValues(&$value, $schema, $path)
                     $this->appliedDefaults[] = $currentProperty;
                 }
             }
-        } elseif (isset($schema->items) && LooseTypeCheck::isArray($value)) {
+        } elseif (
+            isset($schema->items) &&
+            LooseTypeCheck::isArray($schema->items) &&
+            LooseTypeCheck::isArray($value)
+        ) {
             // $value is an array, and items are defined - treat as plain array
             foreach ($schema->items as $currentItem => $itemDefinition) {
                 if (

tests/Constraints/DefaultPropertiesTest.php

@@ -149,6 +149,16 @@ public function getValidTests()
                 '{"items":[{"default":null}]}',
                 '[null]'
             ),
+            array(// #21 items might be an array of schema (instead of an array of schema)
+                '[{}]',
+                '{"items":{"properties":{"propertyOne":{"default":"valueOne"}},"required":[]}}',
+                '[{"propertyOne":"valueOne"}]'
+            ),
+            array(// #22 if items is not an array, it does not create new item
+                '[]',
+                '{"items":{"properties":{"propertyOne":{"default":"valueOne"}},"required":[]}}',
+                '[]'
+            ),
         );
     }