Skip to content

Fix issue when hash has symbol value for type #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Fix issue when hash has symbol value for type #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/jsonapi/rspec/type.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module RSpec
module Type
::RSpec::Matchers.define :have_type do |expected|
match do |actual|
JSONAPI::RSpec.as_indifferent_hash(actual)['type'] == expected.to_s
JSONAPI::RSpec.as_indifferent_hash(actual)['type'].to_s == expected.to_s
end
end
end
Expand Down
8 changes: 8 additions & 0 deletions spec/jsonapi/type_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@
expect('type' => 'foo').to have_type('foo')
end

it 'succeeds when expectation is symbol' do
expect('type' => 'foo').to have_type(:foo)
end

it 'succeeds when type is a symbol' do
expect('type' => :foo).to have_type('foo')
end

it 'fails when type mismatches' do
expect('type' => 'foo').not_to have_type('bar')
end
Expand Down