Skip to content

Allow nil value for JSONAPI::Renderer params include/fields. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2017
Merged

Allow nil value for JSONAPI::Renderer params include/fields. #22

merged 1 commit into from
Jul 12, 2017

Conversation

@beauby
Copy link
Member

@beauby beauby commented Jul 12, 2017 •
edited
Loading

Fixes #20.

houndci-bot
houndci-bot reviewed Jul 12, 2017
View reviewed changes
spec/renderer_spec.rb
end

context 'when fields option is nil' do
it 'does not filter out fields' do
Copy link

@houndci-bot houndci-bot Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [34/25]

spec/renderer_spec.rb
expect(actual).to eq(expected)
end

context 'when fields option is nil' do
Copy link

@houndci-bot houndci-bot Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [36/25]

@codecov
Copy link

codecov bot commented Jul 12, 2017 •
edited
Loading

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files           5        5           
  Lines         153      153           
=======================================
  Hits          151      151           
  Misses          2        2
Impacted Files Coverage Δ
lib/jsonapi/renderer/document.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc35d16...e07dfaa. Read the comment docs.

@beauby beauby merged commit 99ecfc1 into master Jul 12, 2017
@beauby beauby deleted the fix-nil-renderer-params branch July 12, 2017 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beauby @houndci-bot