-
-
Notifications
You must be signed in to change notification settings - Fork 282
Add Navigation into the Japanese #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AQIB-NAWAB , the overall functionality is correct but I noticed a few checks are failing in this PR (related to Cypress). Please take a look and fix them. Thanks a lot!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1765 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 548 548
Branches 158 158
=========================================
Hits 548 548 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@Utkarsh-123github I made changes.Mostly of changes are according to @Deepak-cell311 PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AQIB-NAWAB , the functionality and code changes look great, nice work!
Just a small thing: I noticed there are a few extra spaces in the lib/slugifyMarkdownHeadline.ts file. Could you please format both the files once? After that, it's all good to go for merging.
Hi @Utkarsh-123github , please review |
Hey @AQIB-NAWAB ,I was caught up with some other work, but I’ll make sure to review your PR this weekend. Thanks for your patience! |
Thanks @Utkarsh-123github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🚀
What kind of change does this PR introduce?
This PR allows navigation in Japnese language
Issue Number:
Screenshots/videos:
Screencast from 2025-07-09 09-58-51.webm
If relevant, did you update the documentation?
Summary
Previously navigation was not working in the blog due to Japanese language. This pr fixed that issue.
Does this PR introduce a breaking change?
No
Checklist
Please ensure the following tasks are completed before submitting this pull request.