Skip to content

Add Navigation into the Japanese #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AQIB-NAWAB
Copy link
Contributor

What kind of change does this PR introduce?
This PR allows navigation in Japnese language

Issue Number:

Screenshots/videos:
Screencast from 2025-07-09 09-58-51.webm

If relevant, did you update the documentation?

Summary
Previously navigation was not working in the blog due to Japanese language. This pr fixed that issue.

Does this PR introduce a breaking change?
No

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@AQIB-NAWAB AQIB-NAWAB requested a review from a team as a code owner July 9, 2025 05:00
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Jul 9, 2025
@AQIB-NAWAB AQIB-NAWAB changed the title Add Navigation into the japnese Add Navigation into the Japanese Jul 9, 2025
Copy link

github-actions bot commented Jul 9, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 3e77f05

Copy link
Member

@Utkarsh-123github Utkarsh-123github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AQIB-NAWAB , the overall functionality is correct but I noticed a few checks are failing in this PR (related to Cypress). Please take a look and fix them. Thanks a lot!

@github-project-automation github-project-automation bot moved this from Ready to review to Changes requested in PR - Triage Group Jul 9, 2025
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d585a99) to head (3e77f05).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1765   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          548       548           
  Branches       158       158           
=========================================
  Hits           548       548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AQIB-NAWAB
Copy link
Contributor Author

AQIB-NAWAB commented Jul 9, 2025

@Utkarsh-123github I made changes.Mostly of changes are according to @Deepak-cell311 PR.

Copy link
Member

@Utkarsh-123github Utkarsh-123github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AQIB-NAWAB , the functionality and code changes look great, nice work!
Just a small thing: I noticed there are a few extra spaces in the lib/slugifyMarkdownHeadline.ts file. Could you please format both the files once? After that, it's all good to go for merging.

@AQIB-NAWAB
Copy link
Contributor Author

Hi @Utkarsh-123github , please review

@Utkarsh-123github
Copy link
Member

Hey @AQIB-NAWAB ,I was caught up with some other work, but I’ll make sure to review your PR this weekend. Thanks for your patience!

@AQIB-NAWAB
Copy link
Contributor Author

Hey @AQIB-NAWAB ,I was caught up with some other work, but I’ll make sure to review your PR this weekend. Thanks for your patience!

Thanks @Utkarsh-123github

Copy link
Member

@Utkarsh-123github Utkarsh-123github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@Utkarsh-123github Utkarsh-123github moved this from Changes requested to Waiting for others to Review in PR - Triage Group Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting for others to Review
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Navigatoin is not working in the blog in Japanese
2 participants