Skip to content

Fix/blog preview img #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

animeshsahoo1
Copy link

@animeshsahoo1 animeshsahoo1 commented Jul 5, 2025

What kind of change does this PR introduce?
A Bugfix

Issue Number:
Closes #1755

Screenshots/videos:
object-contain
Adding object contain will make other blog images not fit in properly
object-fill
adding object fill will do the job

Summary
the suggested solution was to use object-contain but that makes other images not fit in properly, instead using object-fill will do the work properly

Does this PR introduce a breaking change?
NO

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@animeshsahoo1 animeshsahoo1 requested a review from a team as a code owner July 5, 2025 08:08
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Jul 5, 2025
Copy link

github-actions bot commented Jul 5, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 0c1a85c

Copy link

codecov bot commented Jul 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d585a99) to head (0c1a85c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1758   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          548       548           
  Branches       158       158           
=========================================
  Hits           548       548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Utkarsh-123github
Copy link
Member

Hi @animeshsahoo1

Hope you're doing well! Just a quick reminder, it would be great if you could wait to get officially assigned to an issue before opening a PR. This helps us manage contributions more smoothly and avoid overlapping efforts.
Really appreciate your enthusiasm and contributions so far, looking forward to more of them!

Thanks a lot for your understanding.

@animeshsahoo1
Copy link
Author

I thought since Benjamin said you can drop PR without assigning the person, but the person stated he isn't working on it. the issue was very small so I thought it didn't need assigning, I will make sure to get it assigned first from next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to review
Development

Successfully merging this pull request may close these issues.

🐛 Bug: JSON blog preview image in homepage is streched
2 participants