-
-
Notifications
You must be signed in to change notification settings - Fork 282
Fix/blog preview img #1758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix/blog preview img #1758
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1758 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 548 548
Branches 158 158
=========================================
Hits 548 548 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hope you're doing well! Just a quick reminder, it would be great if you could wait to get officially assigned to an issue before opening a PR. This helps us manage contributions more smoothly and avoid overlapping efforts. Thanks a lot for your understanding. |
I thought since Benjamin said you can drop PR without assigning the person, but the person stated he isn't working on it. the issue was very small so I thought it didn't need assigning, I will make sure to get it assigned first from next time. |
What kind of change does this PR introduce?
A Bugfix
Issue Number:
Closes #1755
Screenshots/videos:


Adding object contain will make other blog images not fit in properly
adding object fill will do the job
Summary
the suggested solution was to use object-contain but that makes other images not fit in properly, instead using object-fill will do the work properly
Does this PR introduce a breaking change?
NO
Checklist
Please ensure the following tasks are completed before submitting this pull request.