-
-
Notifications
You must be signed in to change notification settings - Fork 282
Migrate Accordion and DocTable components to ShadCN +2 issues resolved #1742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1742 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 30
Lines ? 565
Branches ? 167
========================================
Hits ? 565
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. I added just one comment.
@benjagm I've made the adjustments based on your feedback it looks better now |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
Screen.Recording.2025-06-28.164052.mp4
Summary
Migrated the existing Accordion.tsx, and DocTable.tsx components to the ShadCN library.
Enhanced the styling of the Accordion component
adapted the carbon ads to dark mode
Added Cypress tests for all implemented components to ensure reliability and behavior coverage.
Does this PR introduce a breaking change?
no
Checklist
Please ensure the following tasks are completed before submitting this pull request.