Skip to content

Migrate Accordion and DocTable components to ShadCN +2 issues resolved #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

idanidan29
Copy link
Collaborator

@idanidan29 idanidan29 commented Jun 28, 2025

What kind of change does this PR introduce?

  • Adapted 2 components to use the ShadCN library.
  • Created and adjusted Cypress test files for these 2 components to ensure reliability and behavior coverage.
  • Revamped the the FAQ page and solved and issue related the the FAQ
  • Adapted the carbon ads for dark mode

Issue Number:

Screenshots/videos:

Screen.Recording.2025-06-28.164052.mp4

Image

Summary

Migrated the existing Accordion.tsx, and DocTable.tsx components to the ShadCN library.
Enhanced the styling of the Accordion component
adapted the carbon ads to dark mode
Added Cypress tests for all implemented components to ensure reliability and behavior coverage.

Does this PR introduce a breaking change?

no

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@idanidan29 idanidan29 requested a review from a team as a code owner June 28, 2025 12:48
@idanidan29 idanidan29 changed the title Migrate Accordion and DocTable components to ShadCN Migrate Accordion and DocTable components to ShadCN +2 issues resolved Jun 28, 2025
Copy link

github-actions bot commented Jun 28, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 5130730

Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@7e78fe8). Learn more about missing BASE report.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #1742   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        30           
  Lines           ?       565           
  Branches        ?       167           
========================================
  Hits            ?       565           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I added just one comment.

@idanidan29
Copy link
Collaborator Author

idanidan29 commented Jul 17, 2025

@benjagm I've made the adjustments based on your feedback it looks better now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Adjusting the Carbon Ads to Dark Mode 🐛 Bug: FAQ Accordion Tabs Do Not Close on Repeated Clicks
2 participants