allowing single quotes in 'in' filter with Jackson JSON provider #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't think that this is how it should be fixed. IMHO, the |
Contributor
|
I created #314 with an alternate solution. Sorry for stealing your test. ;-) |
Contributor
Author
|
You are right. Glad I could contribute the testcase :-) |
Contributor
Author
|
Closing in favor of #314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter values in the 'in' filter are treated as JSON. Single quotes in a JSON array are technically not valid JSON. Some JSON parsers allow it by default, others don't. Jackson does not. For consistency this pull-request enables single quotes for Jackson providers. This fixes #275