Fix for OnReturn hook in GetSecondary pipeline #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-degreed
approved these changes
Jan 19, 2021
Contributor
bart-degreed
left a comment
bart-degreed
left a comment
There was a problem hiding this comment.
I tried using TypeHelper.ExtractResources, but it does not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #924
An invalid cast to
IIdentifiablethrew off the hook executor.Additionally, previously the
IResourceService.GetSecondaryAsyncreturned a primary resource with a set relationship field that corresponded to the secondary resources of the request. This has been changed recently to returning just the requested secondary resources. The hook executor also needs to take this into account.