Fixed: splitting on comma in legacy filter notation #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code looked at the first operator and would, unless that operator was 'in' or 'nin', split the query string parameter value on comma. This never worked correctly in composition, because the syntax becomes ambiguous. For example: `?filter[name]=like:a,in:b,c,d` could mean: - like(a), in(b,c,d) - like(a), in(b,c), equals(d) So while this fix addresses the simple case, it still fails on combinations, including mixing with the new notation.
maurei
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #815.
The original code looked at the first operator and would, unless that operator was 'in' or 'nin', split the query string parameter value on comma.
This never worked correctly in composition, because the syntax becomes ambiguous.
For example:
?filter[name]=like:a,in:b,c,dcould mean:So while this fix addresses the simple case, it still fails on combinations, including mixing with the new notation.