Skip to content

Disabled resource hooks by default, as they are still experimental #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Disabled resource hooks by default, as they are still experimental #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Examples/JsonApiDotNetCoreExample/Startups/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public virtual void ConfigureServices(IServiceCollection services)
options.IncludeTotalRecordCount = true;
options.LoadDatabaseValues = true;
options.ValidateModelState = true;
options.EnableResourceHooks = true;
},
discovery => discovery.AddCurrentAssembly());
// once all tests have been moved to WebApplicationFactory format we can get rid of this line below
Expand Down
7 changes: 3 additions & 4 deletions src/JsonApiDotNetCore/Configuration/JsonApiOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,10 @@ public class JsonApiOptions : IJsonApiOptions
public bool IncludeExceptionStackTraceInErrors { get; set; } = false;

/// <summary>
/// Whether or not ResourceHooks are enabled.
///
/// Default is set to <see langword="true"/>
/// Whether or not resource hooks are enabled.
/// This is currently an experimental feature and defaults to <see langword="false"/>.
/// </summary>
public bool EnableResourceHooks { get; set; } = true;
public bool EnableResourceHooks { get; set; } = false;

/// <summary>
/// Whether or not database values should be included by default
Expand Down