Code cleanup#691

Merged

maurei merged 74 commits intojson-api-dotnet:masterfrom

bart-degreed:code-cleanup

Mar 24, 2020

Commits on Feb 14, 2020

Fixed: XML comment is not placed on a valid language element
Bart Koelman
committed
Fixed: Convert to method group
Bart Koelman
committed
Fixed: Use null propagation
Bart Koelman
committed
Fixed: Use string interpolation expression
Bart Koelman
committed
Fixed: Use lambda expression
Bart Koelman
committed
Fixed: Convert to compound assignment
Bart Koelman
committed
Fixed: Convert to 'using' declaration
Bart Koelman
committed
Fixed: Use 'await using'
Bart Koelman
committed
Fixed: Convert to '?:' expression
Bart Koelman
committed
Fixed: Merge conditional expression
Bart Koelman
committed
Fixed: Use object initializer
Bart Koelman
committed
Fixed: Qualifier is redundant
Bart Koelman
committed
Fixed: Using directive is not required by the code and can be safely removed
Bart Koelman
committed
Fixed: Redundant explicit array type specification
Bart Koelman
committed
Fixed: Type argument specification is redundant
Bart Koelman
committed
Fixed: Comparison with true is redundant
Bart Koelman
committed
Fixed: Redundant string interpolation
Bart Koelman
committed
Fixed: Conditional access qualifier expression is known to be not null
Bart Koelman
committed
Fixed: Empty object or collection initializer list is redundant
Bart Koelman
committed
Fixed: Redundant explicit array creation in argument of 'params' parameter
Bart Koelman
committed
Fixed: Type cast is redundant
Bart Koelman
committed
Fixed: The parameter {name} has the same default value
Bart Koelman
committed
Fixed: Empty argument list is redundant
Bart Koelman
committed
Fixed: Expression is always null
Bart Koelman
committed
Fixed: Value assigned is not used in any execution path
Bart Koelman
committed
Fixed: Redundant 'IEnumerable.Cast<T>' call
Bart Koelman
committed
Fixed: '??' right operand is always null
Bart Koelman
committed
Fixed: Redundant 'Object.ToString()' call
Bart Koelman
committed
Fixed: Qualifier 'base.' is redundant
Bart Koelman
committed
Fixed: The field is always assigned before being used and can be converted to local variable
Bart Koelman
committed
Fixed: Merge cast with type check
Bart Koelman
committed

Commits on Feb 17, 2020

Fixed: Replace with single call to First(..)
Bart Koelman
committed
Fixed: Replace 'Enumerable.Count()' invocation with collection count property access
Bart Koelman
committed
Fixed: Use format specifier
Bart Koelman
committed
Fixed: Field is assigned but its value is never used
Bart Koelman
committed
Fixed: Field can be made readonly
Bart Koelman
committed
Fixed: Redundant method override
Bart Koelman
committed
Fixed: Method is never used
Bart Koelman
committed
Fixed: Base interface is redundant
Bart Koelman
committed
Fixed: Field is never used
Bart Koelman
committed
Fixed: Local variable is never used
Bart Koelman
committed
Fixed: Method return value is never used
Bart Koelman
committed
Fixed: Constructor is never used
Bart Koelman
committed
Fixed: shared instance is never used
Bart Koelman
committed
Fixed: Parameter is never used
Bart Koelman
committed
Fixed: Method is never used
Bart Koelman
committed
Fixed: Initializing field/property by default value is redundant
Bart Koelman
committed
Fixed: Redundant base constructor call
Bart Koelman
committed
Fixed: parameter hides outer local variable with the same name
Bart Koelman
committed
Fixed: Cannot resolve symbol 'dynamic'
Bart Koelman
committed
Fixed: Possible unintended reference comparison
Bart Koelman
committed
Fixed: Co-variant array conversion can cause run-time exception on write operation
Bart Koelman
committed
Fixed: Return value of pure method is not used
Bart Koelman
committed
Fixed: Auto-property can be made get-only
Bart Koelman
committed
Fixed: Inconsistent body style: use expression-bodied property
Bart Koelman
committed
Fixed: Empty statement is redundant
Bart Koelman
committed
Fixed: Local variable can be declared in inner scope
Bart Koelman
committed
Fixed: Join declaration and assignment
Bart Koelman
committed
Fixed: Convert constructor to protected in abstract class
Bart Koelman
committed
Fixed: Replace with single call to FirstOrDefault/Count
Bart Koelman
committed
Fixed: Use single deconstruction declaration
Bart Koelman
committed
Fixed: Removed unused using directives
Bart Koelman
committed
Fixed a few obvious naming violations
Bart Koelman
committed
Fixed: Virtual member that is never overridden
Bart Koelman
committed
Removed DefaultPageSize/RequestedPageSize from IPageService because where the calculated value comes from is an implementation detail and should not be exposed to external code that uses paging.
Bart Koelman
committed
Fixed: Initializing property by default value is redundant
Bart Koelman
committed
Reduced accessibility for some non-public types/members
Bart Koelman
committed
Fixed: missing checkbox in Solution Configuration Manager
Bart Koelman
committed
Made non-public (and a few public) types sealed
Bart Koelman
committed
Fixed: Inconsistent modifiers style
Bart Koelman
committed
Removed reference to xunit from benchmarks project, so that 'dotnet test' does not try to run tests from it
Bart Koelman
committed
Empty commit to retry cibuild
Bart Koelman
committed

Commits on Mar 24, 2020