Fixed broken build #680
Merged
Fixed broken build #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We didn't catch this because the benchmark project isn't included in the CI build. We should look into either separating the benchmark project into a dedicated repo or add the benchmark project to the CI pipeline. But thx for this hotfix! |
maurei
approved these changes
Feb 12, 2020
Contributor
Author
|
Yes, I've already implemented building and testing of all projects in cibuild, but wanted to hold off a PR because PRs were piling up and this one would become dependent on others. Now that affected PRs have been merged, I'll start work on getting a PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by enabling benchmarks (#677), combined with removing resourceGraph dependency (#672).