Repaired the broken benchmarks project #677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
SortService.CheckIfProcessed(), which was supposed to disallow multiple sort parameters. But it never worked. For example, if you passhttp://host/path?sort=a&sort=b, it gets translated byMicrosoft.AspNetCore.Http.QueryCollectioninto value "a,b". The check prevented to run benchmarks multiple times.Also reactivated the build flag on all combinations of Platform/Configuration in Solution Configuration Manager for all projects.
Removed some benchmarks, for which no equivalent code exists anymore. But kept the benchmark on namespace-from-path extraction (and optimized a bit), because it nicely shows the perf difference between using strings and
ReadOnlySpan<char>.Also deleted old output markdown files from source control, as they differ per machine.
Finally, the stats from my laptop: