Feature/#162 #262
Merged
Feature/#162 #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceAttribute. Updates DefaultEntityRepository to check this value when including relationship entities and to throw if set to false.
…eAttribute property.
jaredcnance
suggested changes
Apr 22, 2018
Contributor
jaredcnance
left a comment
jaredcnance
left a comment
There was a problem hiding this comment.
Looks great! Thanks for doing this. Only one minor comment and we're good to go.
| [HasMany("todo-collections")] | ||
| public virtual List<TodoItemCollection> TodoItemCollections { get; set; } | ||
|
|
||
| [HasOne("unincludeable-item", Link.All, false)] |
Contributor
There was a problem hiding this comment.
Can you change this to include the canInclude parameter name?
[HasOne("unincludeable-item", Link.All, canInclude : false)]These examples serve as documentation, so being explicit improves readability.
| { | ||
| var attr = obj as RelationshipAttribute; | ||
| if (attr == null) | ||
| if (!(obj is RelationshipAttribute attr)) |
jaredcnance
approved these changes
Apr 23, 2018
jaredcnance
added a commit
that referenced
this pull request
Aug 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162
FEATURE
bump package versionthis will go out in the 2.2.2 release, bumped by make private service methods protected virtual #265