Skip to content

Remove unused PGPASSWORD environment variable #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Remove unused PGPASSWORD environment variable #1436

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b01e414
Remove unused PGPASSWORD environment variable
bkoelman Jan 13, 2024
a89d3f1
Bump action-setup-postgres version
bkoelman Jan 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ concurrency:
env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
DOTNET_CLI_TELEMETRY_OPTOUT: true
# The Windows runner image has PostgreSQL pre-installed and sets the PGPASSWORD environment variable to "root".
# This conflicts with the default password "postgres", which is used by ikalnytskyi/action-setup-postgres.
# Because action-setup-postgres forgets to update the environment variable accordingly, we do so here.
PGPASSWORD: "postgres"

jobs:
build-and-test:
Expand All @@ -42,7 +38,7 @@ jobs:
- name: Tune GitHub-hosted runner network
uses: smorimoto/tune-github-hosted-runner-network@v1
- name: Setup PostgreSQL
uses: ikalnytskyi/action-setup-postgres@v4
uses: ikalnytskyi/action-setup-postgres@v5
with:
username: postgres
password: postgres
Expand Down