From 9334a95612b957a941183d481fff9000551ff544 Mon Sep 17 00:00:00 2001 From: Bart Koelman <10324372+bkoelman@users.noreply.github.com> Date: Wed, 4 Oct 2023 12:52:25 +0200 Subject: [PATCH] Remove redundant suppressions after update to CSharpGuidelinesAnalyzer v3.8.4 --- .../ControllerSourceGenerator.cs | 2 -- .../UnitTests/Links/LinkInclusionTests.cs | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/JsonApiDotNetCore.SourceGenerators/ControllerSourceGenerator.cs b/src/JsonApiDotNetCore.SourceGenerators/ControllerSourceGenerator.cs index 89a511b08e..1b47821d22 100644 --- a/src/JsonApiDotNetCore.SourceGenerators/ControllerSourceGenerator.cs +++ b/src/JsonApiDotNetCore.SourceGenerators/ControllerSourceGenerator.cs @@ -6,8 +6,6 @@ using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Text; -#pragma warning disable RS2008 // Enable analyzer release tracking - namespace JsonApiDotNetCore.SourceGenerators; // To debug in Visual Studio (requires v17.2 or higher): // - Set JsonApiDotNetCore.SourceGenerators as startup project diff --git a/test/JsonApiDotNetCoreTests/UnitTests/Links/LinkInclusionTests.cs b/test/JsonApiDotNetCoreTests/UnitTests/Links/LinkInclusionTests.cs index 52dc5cb19c..03cb0e2a4c 100644 --- a/test/JsonApiDotNetCoreTests/UnitTests/Links/LinkInclusionTests.cs +++ b/test/JsonApiDotNetCoreTests/UnitTests/Links/LinkInclusionTests.cs @@ -403,7 +403,6 @@ public ResourceType GetResourceTypeForController(Type? controllerType) private sealed class FakeLinkGenerator : LinkGenerator { -#pragma warning disable AV1553 // Do not use optional parameters with default value null for strings, collections or tasks public override string GetPathByAddress(HttpContext httpContext, TAddress address, RouteValueDictionary values, RouteValueDictionary? ambientValues = null, PathString? pathBase = null, FragmentString fragment = new(), LinkOptions? options = null) { @@ -428,6 +427,5 @@ public override string GetUriByAddress(TAddress address, RouteValueDic { throw new NotImplementedException(); } -#pragma warning restore AV1553 // Do not use optional parameters with default value null for strings, collections or tasks } }