Simplify meta:total assertions and produce better error on failure

Before: Expected element.GetInt32() to be 25, but found 2 (difference of -23).
After: Expected responseDocument.Meta to be 25, but found 2 (difference of -23).

Author: bkoelman

test/JsonApiDotNetCoreTests/IntegrationTests/Meta/TopLevelCountTests.cs

@@ -1,5 +1,4 @@
 using System.Net;
-using System.Text.Json;
 using FluentAssertions;
 using JsonApiDotNetCore.Configuration;
 using JsonApiDotNetCore.Resources;
@@ -54,11 +53,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         // Assert
         httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
 
-        responseDocument.Meta.ShouldContainKey("total").With(value =>
-        {
-            JsonElement element = value.Should().BeOfType<JsonElement>().Subject;
-            element.GetInt32().Should().Be(1);
-        });
+        responseDocument.Meta.Should().ContainTotal(1);
     }
 
     [Fact]
@@ -84,11 +79,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         // Assert
         httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
 
-        responseDocument.Meta.ShouldContainKey("total").With(value =>
-        {
-            JsonElement element = value.Should().BeOfType<JsonElement>().Subject;
-            element.GetInt32().Should().Be(1);
-        });
+        responseDocument.Meta.Should().ContainTotal(1);
     }
 
     [Fact]
@@ -108,11 +99,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         // Assert
         httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
 
-        responseDocument.Meta.ShouldContainKey("total").With(value =>
-        {
-            JsonElement element = value.Should().BeOfType<JsonElement>().Subject;
-            element.GetInt32().Should().Be(0);
-        });
+        responseDocument.Meta.Should().ContainTotal(0);
     }
 
     [Fact]

test/JsonApiDotNetCoreTests/IntegrationTests/NamingConventions/KebabCasingTests.cs

@@ -1,5 +1,4 @@
 using System.Net;
-using System.Text.Json;
 using FluentAssertions;
 using JsonApiDotNetCore.Serialization.Objects;
 using TestBuildingBlocks;
@@ -57,11 +56,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         responseDocument.Included[0].Relationships.Should().BeNull();
         responseDocument.Included[0].Links.ShouldNotBeNull().Self.Should().Be($"/public-api/diving-boards/{pools[1].DivingBoards[0].StringId}");
 
-        responseDocument.Meta.ShouldContainKey("total").With(value =>
-        {
-            JsonElement element = value.Should().BeOfType<JsonElement>().Subject;
-            element.GetInt32().Should().Be(2);
-        });
+        responseDocument.Meta.Should().ContainTotal(2);
     }
 
     [Fact]

test/JsonApiDotNetCoreTests/IntegrationTests/ResourceDefinitions/Reading/ResourceDefinitionReadTests.cs

@@ -1,5 +1,4 @@
 using System.Net;
-using System.Text.Json;
 using FluentAssertions;
 using JsonApiDotNetCore.Configuration;
 using JsonApiDotNetCore.Serialization.Objects;
@@ -238,11 +237,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         responseDocument.Data.ManyValue[0].Id.Should().Be(planets[1].StringId);
         responseDocument.Data.ManyValue[1].Id.Should().Be(planets[3].StringId);
 
-        responseDocument.Meta.ShouldContainKey("total").With(value =>
-        {
-            JsonElement element = value.Should().BeOfType<JsonElement>().Subject;
-            element.GetInt32().Should().Be(2);
-        });
+        responseDocument.Meta.Should().ContainTotal(2);
 
         hitCounter.HitExtensibilityPoints.Should().BeEquivalentTo(new[]
         {
@@ -297,11 +292,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         responseDocument.Data.ManyValue.ShouldHaveCount(1);
         responseDocument.Data.ManyValue[0].Id.Should().Be(planets[3].StringId);
 
-        responseDocument.Meta.ShouldContainKey("total").With(value =>
-        {
-            JsonElement element = value.Should().BeOfType<JsonElement>().Subject;
-            element.GetInt32().Should().Be(1);
-        });
+        responseDocument.Meta.Should().ContainTotal(1);
 
         hitCounter.HitExtensibilityPoints.Should().BeEquivalentTo(new[]
         {
@@ -349,11 +340,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         responseDocument.Data.ManyValue[0].Id.Should().Be(star.Planets.ElementAt(1).StringId);
         responseDocument.Data.ManyValue[1].Id.Should().Be(star.Planets.ElementAt(3).StringId);
 
-        responseDocument.Meta.ShouldContainKey("total").With(value =>
-        {
-            JsonElement element = value.Should().BeOfType<JsonElement>().Subject;
-            element.GetInt32().Should().Be(2);
-        });
+        responseDocument.Meta.Should().ContainTotal(2);
 
         hitCounter.HitExtensibilityPoints.Should().BeEquivalentTo(new[]
         {
@@ -405,11 +392,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         responseDocument.Data.ManyValue[0].Id.Should().Be(star.Planets.ElementAt(1).StringId);
         responseDocument.Data.ManyValue[1].Id.Should().Be(star.Planets.ElementAt(3).StringId);
 
-        responseDocument.Meta.ShouldContainKey("total").With(value =>
-        {
-            JsonElement element = value.Should().BeOfType<JsonElement>().Subject;
-            element.GetInt32().Should().Be(2);
-        });
+        responseDocument.Meta.Should().ContainTotal(2);
 
         hitCounter.HitExtensibilityPoints.Should().BeEquivalentTo(new[]
         {

test/TestBuildingBlocks/ObjectAssertionsExtensions.cs

@@ -2,6 +2,7 @@
 using System.Text.Encodings.Web;
 using System.Text.Json;
 using FluentAssertions;
+using FluentAssertions.Collections;
 using FluentAssertions.Numeric;
 using FluentAssertions.Primitives;
 using JetBrains.Annotations;
@@ -65,4 +66,13 @@ private static string ToJsonString(JsonDocument document)
         writer.Flush();
         return Encoding.UTF8.GetString(stream.ToArray());
     }
+
+    /// <summary>
+    /// Asserts that a "meta" dictionary contains a single element named "total" with the specified value.
+    /// </summary>
+    [CustomAssertion]
+    public static void ContainTotal(this GenericDictionaryAssertions<IDictionary<string, object?>, string, object?> source, int expectedTotal)
+    {
+        source.ContainKey("total").WhoseValue.Should().BeOfType<JsonElement>().Subject.GetInt32().Should().Be(expectedTotal);
+    }
 }