Tryout: update to latest JetBrains tools to diagnose cibuild

Author: Bart Koelman

.config/dotnet-tools.json

@@ -3,7 +3,7 @@
   "isRoot": true,
   "tools": {
     "jetbrains.resharper.globaltools": {
-      "version": "2021.1.4",
+      "version": "2021.2.2",
       "commands": [
         "jb"
       ]

Build.ps1

@@ -100,7 +100,7 @@ dotnet build -c Release
 CheckLastExitCode
 
 RunInspectCode
-#RunCleanupCode
+RunCleanupCode
 
 dotnet test -c Release --no-build --collect:"XPlat Code Coverage"
 CheckLastExitCode

benchmarks/Deserialization/OperationsDeserializationBenchmarks.cs

@@ -276,7 +276,7 @@ public class OperationsDeserializationBenchmarks : DeserializationBenchmarkBase
 
         protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)
         {
-            return new()
+            return new JsonApiRequest
             {
                 Kind = EndpointKind.AtomicOperations
             };

benchmarks/Deserialization/ResourceDeserializationBenchmarks.cs

@@ -139,7 +139,7 @@ public class ResourceDeserializationBenchmarks : DeserializationBenchmarkBase
 
         protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)
         {
-            return new()
+            return new JsonApiRequest
             {
                 Kind = EndpointKind.Primary,
                 PrimaryResourceType = resourceGraph.GetResourceType<IncomingResource>(),

benchmarks/Serialization/OperationsSerializationBenchmarks.cs

@@ -122,7 +122,7 @@ public string SerializeOperationsResponse()
 
         protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)
         {
-            return new()
+            return new JsonApiRequest
             {
                 Kind = EndpointKind.AtomicOperations,
                 PrimaryResourceType = resourceGraph.GetResourceType<OutgoingResource>()

benchmarks/Serialization/ResourceSerializationBenchmarks.cs

@@ -113,7 +113,7 @@ public string SerializeResourceResponse()
 
         protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)
         {
-            return new()
+            return new JsonApiRequest
             {
                 Kind = EndpointKind.Primary,
                 PrimaryResourceType = resourceGraph.GetResourceType<OutgoingResource>()

benchmarks/Serialization/SerializationBenchmarkBase.cs

@@ -223,23 +223,23 @@ private sealed class FakeLinkBuilder : ILinkBuilder
         {
             public TopLevelLinks GetTopLevelLinks()
             {
-                return new()
+                return new TopLevelLinks
                 {
                     Self = "TopLevel:Self"
                 };
             }
 
             public ResourceLinks GetResourceLinks(ResourceType resourceType, string id)
             {
-                return new()
+                return new ResourceLinks
                 {
                     Self = "Resource:Self"
                 };
             }
 
             public RelationshipLinks GetRelationshipLinks(RelationshipAttribute relationship, string leftId)
             {
-                return new()
+                return new RelationshipLinks
                 {
                     Self = "Relationship:Self",
                     Related = "Relationship:Related"

src/JsonApiDotNetCore/Errors/ResourcesInRelationshipsNotFoundException.cs

@@ -19,7 +19,7 @@ public ResourcesInRelationshipsNotFoundException(IEnumerable<MissingResourceInRe
 
         private static ErrorObject CreateError(MissingResourceInRelationship missingResourceInRelationship)
         {
-            return new(HttpStatusCode.NotFound)
+            return new ErrorObject(HttpStatusCode.NotFound)
             {
                 Title = "A related resource does not exist.",
                 Detail = $"Related resource of type '{missingResourceInRelationship.ResourceType}' with ID '{missingResourceInRelationship.ResourceId}' " +

src/JsonApiDotNetCore/ObjectExtensions.cs

@@ -21,15 +21,15 @@ public static T[] AsArray<T>(this T element)
 
         public static List<T> AsList<T>(this T element)
         {
-            return new()
+            return new List<T>
             {
                 element
             };
         }
 
         public static HashSet<T> AsHashSet<T>(this T element)
         {
-            return new()
+            return new HashSet<T>
             {
                 element
             };

src/JsonApiDotNetCore/Serialization/JsonConverters/JsonObjectConverter.cs

@@ -29,7 +29,7 @@ protected static void WriteSubTree<TValue>(Utf8JsonWriter writer, TValue value,
 
         protected static JsonException GetEndOfStreamError()
         {
-            return new("Unexpected end of JSON stream.");
+            return new JsonException("Unexpected end of JSON stream.");
         }
     }
 }