TestContext: Only dispose factory when created

Author: Bart Koelman

test/JsonApiDotNetCoreTests/IntegrationTests/NonJsonApiControllers/DuplicateResourceControllerTests.cs

@@ -22,9 +22,4 @@ public void Fails_at_startup_when_multiple_controllers_exist_for_same_resource_t
         // Assert
         action.Should().ThrowExactly<InvalidConfigurationException>().WithMessage("Multiple controllers found for resource type 'knownResources'.");
     }
-
-    public override void Dispose()
-    {
-        // Prevents crash when test cleanup tries to access lazily constructed Factory.
-    }
 }

test/JsonApiDotNetCoreTests/IntegrationTests/NonJsonApiControllers/UnknownResourceControllerTests.cs

@@ -22,9 +22,4 @@ public void Fails_at_startup_when_using_controller_for_resource_type_that_is_not
         action.Should().ThrowExactly<InvalidConfigurationException>().WithMessage($"Controller '{typeof(UnknownResourcesController)}' " +
             $"depends on resource type '{typeof(UnknownResource)}', which does not exist in the resource graph.");
     }
-
-    public override void Dispose()
-    {
-        // Prevents crash when test cleanup tries to access lazily constructed Factory.
-    }
 }

test/TestBuildingBlocks/IntegrationTestContext.cs

@@ -103,11 +103,14 @@ private WebApplicationFactory<TStartup> CreateFactory()
         return factoryWithConfiguredContentRoot;
     }
 
-    public virtual void Dispose()
+    public void Dispose()
     {
-        RunOnDatabaseAsync(async dbContext => await dbContext.Database.EnsureDeletedAsync()).Wait();
+        if (_lazyFactory.IsValueCreated)
+        {
+            RunOnDatabaseAsync(async dbContext => await dbContext.Database.EnsureDeletedAsync()).Wait();
 
-        Factory.Dispose();
+            _lazyFactory.Value.Dispose();
+        }
     }
 
     public void ConfigureLogging(Action<ILoggingBuilder> loggingConfiguration)