Resharper quickfix: Use negated pattern

Author: Bart Koelman

src/JsonApiDotNetCore/Middleware/AsyncConvertEmptyActionResultFilter.cs

@@ -16,7 +16,7 @@ public async Task OnResultExecutionAsync(ResultExecutingContext context, ResultE
 
             if (context.HttpContext.IsJsonApiRequest())
             {
-                if (!(context.Result is ObjectResult objectResult) || objectResult.Value == null)
+                if (context.Result is not ObjectResult objectResult || objectResult.Value == null)
                 {
                     if (context.Result is IStatusCodeActionResult statusCodeResult)
                     {

src/JsonApiDotNetCore/Queries/Internal/Parsing/FilterParser.cs

@@ -152,7 +152,7 @@ protected ComparisonExpression ParseComparison(string operatorName)
 
             if (leftTerm is ResourceFieldChainExpression leftChain)
             {
-                if (leftChainRequirements.HasFlag(FieldChainRequirements.EndsInToOne) && !(rightTerm is NullConstantExpression))
+                if (leftChainRequirements.HasFlag(FieldChainRequirements.EndsInToOne) && rightTerm is not NullConstantExpression)
                 {
                     // Run another pass over left chain to have it fail when chain ends in relationship.
                     OnResolveFieldChain(leftChain.ToString(), FieldChainRequirements.EndsInAttribute);

src/JsonApiDotNetCore/Queries/Internal/Parsing/ResourceFieldChainResolver.cs

@@ -213,7 +213,7 @@ private RelationshipAttribute GetToManyRelationship(string publicName, ResourceC
         {
             RelationshipAttribute relationship = GetRelationship(publicName, resourceContext, path);
 
-            if (!(relationship is HasManyAttribute))
+            if (relationship is not HasManyAttribute)
             {
                 throw new QueryParseException(path == publicName
                     ? $"Relationship '{publicName}' must be a to-many relationship on resource '{resourceContext.PublicName}'."
@@ -227,7 +227,7 @@ private RelationshipAttribute GetToOneRelationship(string publicName, ResourceCo
         {
             RelationshipAttribute relationship = GetRelationship(publicName, resourceContext, path);
 
-            if (!(relationship is HasOneAttribute))
+            if (relationship is not HasOneAttribute)
             {
                 throw new QueryParseException(path == publicName
                     ? $"Relationship '{publicName}' must be a to-one relationship on resource '{resourceContext.PublicName}'."

src/JsonApiDotNetCore/Repositories/ResourceRepositoryAccessor.cs

@@ -148,7 +148,7 @@ private object GetWriteRepository(Type resourceType)
 
             if (_request.TransactionId != null)
             {
-                if (!(writeRepository is IRepositorySupportsTransaction repository))
+                if (writeRepository is not IRepositorySupportsTransaction repository)
                 {
                     ResourceContext resourceContext = _resourceContextProvider.GetResourceContext(resourceType);
                     throw new MissingTransactionSupportException(resourceContext.PublicName);

src/JsonApiDotNetCore/Serialization/JsonApiReader.cs

@@ -258,14 +258,14 @@ private void ValidateForRelationshipType(string requestMethod, object model, str
                     throw new ToManyRelationshipRequiredException(_request.Relationship.PublicName);
                 }
 
-                if (model != null && !(model is IIdentifiable))
+                if (model is { } and not IIdentifiable)
                 {
                     throw new InvalidRequestBodyException("Expected single data element for to-one relationship.",
                         $"Expected single data element for '{_request.Relationship.PublicName}' relationship.", body);
                 }
             }
 
-            if (_request.Relationship is HasManyAttribute && !(model is IEnumerable<IIdentifiable>))
+            if (_request.Relationship is HasManyAttribute && model is not IEnumerable<IIdentifiable>)
             {
                 throw new InvalidRequestBodyException("Expected data[] element for to-many relationship.",
                     $"Expected data[] element for '{_request.Relationship.PublicName}' relationship.", body);

test/UnitTests/Builders/ResourceGraphBuilderTests.cs

@@ -78,7 +78,7 @@ public void Relationships_Without_Names_Specified_Will_Use_Configured_Formatter(
             // Assert
             ResourceContext resource = resourceGraph.GetResourceContext(typeof(TestResource));
             Assert.Equal("relatedResource", resource.Relationships.Single(relationship => relationship is HasOneAttribute).PublicName);
-            Assert.Equal("relatedResources", resource.Relationships.Single(relationship => !(relationship is HasOneAttribute)).PublicName);
+            Assert.Equal("relatedResources", resource.Relationships.Single(relationship => relationship is not HasOneAttribute).PublicName);
         }
 
         private sealed class NonDbResource : Identifiable