Removed Resource Hooks

Author: Bart Koelman

docs/usage/extensibility/services.md

@@ -18,10 +18,9 @@ public class TodoItemService : JsonApiResourceService<TodoItem>
     public TodoItemService(IResourceRepositoryAccessor repositoryAccessor,
         IQueryLayerComposer queryLayerComposer, IPaginationContext paginationContext,
         IJsonApiOptions options, ILoggerFactory loggerFactory, IJsonApiRequest request,
-        IResourceChangeTracker<TodoItem> resourceChangeTracker,
-        IResourceHookExecutorFacade hookExecutor)
+        IResourceChangeTracker<TodoItem> resourceChangeTracker)
         : base(repositoryAccessor, queryLayerComposer, paginationContext, options,
-            loggerFactory, request, resourceChangeTracker, hookExecutor)
+            loggerFactory, request, resourceChangeTracker)
     {
         _notificationService = notificationService;
     }

docs/usage/resources/hooks.md

@@ -6,7 +6,7 @@
 
 namespace JsonApiDotNetCore
 {
-    internal class CollectionConverter
+    internal sealed class CollectionConverter
     {
         private static readonly Type[] HashSetCompatibleCollectionTypes =
         {

src/JsonApiDotNetCore/CollectionConverter.cs

@@ -5,9 +5,8 @@ namespace JsonApiDotNetCore.Configuration
 {
     /// <summary>
     /// Responsible for populating <see cref="RelationshipAttribute.InverseNavigationProperty" />. This service is instantiated in the configure phase of the
-    /// application. When using a data access layer different from EF Core, and when using ResourceHooks that depend on the inverse navigation property
-    /// (BeforeImplicitUpdateRelationship), you will need to override this service, or set <see cref="RelationshipAttribute.InverseNavigationProperty" />
-    /// explicitly.
+    /// application. When using a data access layer different from EF Core, you will need to implement and register this service, or set
+    /// <see cref="RelationshipAttribute.InverseNavigationProperty" /> explicitly.
     /// </summary>
     [PublicAPI]
     public interface IInverseNavigationResolver

src/JsonApiDotNetCore/Configuration/GenericServiceFactory.cs

@@ -118,16 +118,6 @@ internal NamingStrategy SerializerNamingStrategy
         /// </summary>
         bool AllowClientGeneratedIds { get; }
 
-        /// <summary>
-        /// Whether or not resource hooks are enabled. This is currently an experimental feature and subject to change in future versions. Defaults to False.
-        /// </summary>
-        public bool EnableResourceHooks { get; }
-
-        /// <summary>
-        /// Whether or not database values should be included by default for resource hooks. Ignored if EnableResourceHooks is set to false. False by default.
-        /// </summary>
-        bool LoadDatabaseValues { get; }
-
         /// <summary>
         /// Whether or not to produce an error on unknown query string parameters. False by default.
         /// </summary>

src/JsonApiDotNetCore/Configuration/IGenericServiceFactory.cs

@@ -3,11 +3,6 @@
 using System.Linq;
 using JsonApiDotNetCore.AtomicOperations;
 using JsonApiDotNetCore.AtomicOperations.Processors;
-using JsonApiDotNetCore.Hooks;
-using JsonApiDotNetCore.Hooks.Internal;
-using JsonApiDotNetCore.Hooks.Internal.Discovery;
-using JsonApiDotNetCore.Hooks.Internal.Execution;
-using JsonApiDotNetCore.Hooks.Internal.Traversal;
 using JsonApiDotNetCore.Middleware;
 using JsonApiDotNetCore.Queries;
 using JsonApiDotNetCore.Queries.Internal;
@@ -153,9 +148,6 @@ public void ConfigureServiceContainer(ICollection<Type> dbContextTypes)
             AddQueryStringLayer();
             AddOperationsLayer();
 
-            AddResourceHooks();
-
-            _services.AddScoped<IGenericServiceFactory, GenericServiceFactory>();
             _services.AddScoped(typeof(IResourceChangeTracker<>), typeof(ResourceChangeTracker<>));
             _services.AddScoped<IPaginationContext, PaginationContext>();
             _services.AddScoped<IEvaluatedIncludeCache, EvaluatedIncludeCache>();
@@ -256,23 +248,6 @@ private void RegisterDependentService<TCollectionElement, TElementToAdd>()
             _services.AddScoped<TCollectionElement>(serviceProvider => serviceProvider.GetRequiredService<TElementToAdd>());
         }
 
-        private void AddResourceHooks()
-        {
-            if (_options.EnableResourceHooks)
-            {
-                _services.AddSingleton(typeof(IHooksDiscovery<>), typeof(HooksDiscovery<>));
-                _services.AddScoped(typeof(IResourceHookContainer<>), typeof(ResourceHooksDefinition<>));
-                _services.AddTransient<IResourceHookExecutor, ResourceHookExecutor>();
-                _services.AddTransient<IHookContainerProvider, HookContainerProvider>();
-                _services.AddScoped<INodeNavigator, NodeNavigator>();
-                _services.AddScoped<IResourceHookExecutorFacade, ResourceHookExecutorFacade>();
-            }
-            else
-            {
-                _services.AddSingleton<IResourceHookExecutorFacade, NeverResourceHookExecutorFacade>();
-            }
-        }
-
         private void AddSerializationLayer()
         {
             _services.AddScoped<IIncludedResourceObjectBuilder, IncludedResourceObjectBuilder>();

src/JsonApiDotNetCore/Configuration/IInverseNavigationResolver.cs

@@ -58,12 +58,6 @@ public sealed class JsonApiOptions : IJsonApiOptions
         /// <inheritdoc />
         public bool AllowClientGeneratedIds { get; set; }
 
-        /// <inheritdoc />
-        public bool EnableResourceHooks { get; set; }
-
-        /// <inheritdoc />
-        public bool LoadDatabaseValues { get; set; }
-
         /// <inheritdoc />
         public bool AllowUnknownQueryStringParameters { get; set; }
 

src/JsonApiDotNetCore/Configuration/IJsonApiOptions.cs

@@ -1,9 +1,7 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Reflection;
 using JetBrains.Annotations;
-using JsonApiDotNetCore.Errors;
 using JsonApiDotNetCore.Repositories;
 using JsonApiDotNetCore.Resources;
 using JsonApiDotNetCore.Services;
@@ -134,11 +132,6 @@ private void AddInjectables(IReadOnlyCollection<ResourceDescriptor> resourceDesc
                 AddServices(assembly, resourceDescriptor);
                 AddRepositories(assembly, resourceDescriptor);
                 AddResourceDefinitions(assembly, resourceDescriptor);
-
-                if (_options.EnableResourceHooks)
-                {
-                    AddResourceHookDefinitions(assembly, resourceDescriptor);
-                }
             }
         }
 
@@ -158,25 +151,6 @@ private void AddResource(ResourceDescriptor resourceDescriptor)
             _resourceGraphBuilder.Add(resourceDescriptor.ResourceType, resourceDescriptor.IdType);
         }
 
-        private void AddResourceHookDefinitions(Assembly assembly, ResourceDescriptor identifiable)
-        {
-            try
-            {
-                Type resourceDefinition = _typeLocator.GetDerivedGenericTypes(assembly, typeof(ResourceHooksDefinition<>), identifiable.ResourceType)
-                    .SingleOrDefault();
-
-                if (resourceDefinition != null)
-                {
-                    _services.AddScoped(typeof(ResourceHooksDefinition<>).MakeGenericType(identifiable.ResourceType), resourceDefinition);
-                }
-            }
-            catch (InvalidOperationException exception)
-            {
-                throw new InvalidConfigurationException($"Cannot define multiple ResourceHooksDefinition<> implementations for '{identifiable.ResourceType}'",
-                    exception);
-            }
-        }
-
         private void AddServices(Assembly assembly, ResourceDescriptor resourceDescriptor)
         {
             foreach (Type serviceInterface in ServiceInterfaces)