Unified naming: exclude -> omit

Author: lheiskan

src/JsonApiDotNetCore/Builders/DocumentBuilder.cs

@@ -129,13 +129,13 @@ private DocumentData GetData(ContextEntity contextEntity, IIdentifiable entity)
 
         private bool ShouldIncludeAttribute(AttrAttribute attr, object attributeValue)
         {
-            return !ExcludeNullValuedAttribute(attr, attributeValue)
+            return !OmitNullValuedAttribute(attr, attributeValue)
                    && ((_jsonApiContext.QuerySet == null
                        || _jsonApiContext.QuerySet.Fields.Count == 0)
                        || _jsonApiContext.QuerySet.Fields.Contains(attr.InternalAttributeName));
         }
 
-        private bool ExcludeNullValuedAttribute(AttrAttribute attr, object attributeValue)
+        private bool OmitNullValuedAttribute(AttrAttribute attr, object attributeValue)
         {
             return attributeValue == null && _documentBuilderOptions.OmitNullValuedAttributes;
         }

test/UnitTests/Builders/DocumentBuilder_Tests.cs

@@ -151,17 +151,17 @@ public void Build_Can_Build_CustomIEnumerables()
         [InlineData(null,"foo",true)]
         [InlineData(false,"foo",true)]
         [InlineData(true,"foo",true)]
-        public void DocumentBuilderOptions(bool? excludeNullValuedAttributes,
+        public void DocumentBuilderOptions(bool? omitNullValuedAttributes,
             string attributeValue,
             bool resultContainsAttribute)
         {
             var documentBuilderBehaviourMock = new Mock<IDocumentBuilderBehavior>();
-            if (excludeNullValuedAttributes.HasValue)
+            if (omitNullValuedAttributes.HasValue)
             {
                 documentBuilderBehaviourMock.Setup(m => m.GetDocumentBuilderOptions())
-                    .Returns(new DocumentBuilderOptions(excludeNullValuedAttributes.Value));
+                    .Returns(new DocumentBuilderOptions(omitNullValuedAttributes.Value));
             }
-            var documentBuilder = new DocumentBuilder(_jsonApiContextMock.Object, null, excludeNullValuedAttributes.HasValue ? documentBuilderBehaviourMock.Object : null);
+            var documentBuilder = new DocumentBuilder(_jsonApiContextMock.Object, null, omitNullValuedAttributes.HasValue ? documentBuilderBehaviourMock.Object : null);
             var document = documentBuilder.Build(new Model(){StringProperty = attributeValue});
 
             Assert.Equal(resultContainsAttribute, document.Data.Attributes.ContainsKey("StringProperty"));