fix: merge II

Author: maurei

src/JsonApiDotNetCore/Configuration/JsonApiApplicationBuilder.cs

@@ -40,8 +40,8 @@ internal sealed class JsonApiApplicationBuilder : IJsonApiApplicationBuilder
 
         public JsonApiApplicationBuilder(IServiceCollection services, IMvcCoreBuilder mvcBuilder)
         {
-            _services = services;
-            _mvcBuilder = mvcBuilder;
+            _services = services ?? throw new ArgumentNullException(nameof(services));
+            _mvcBuilder = mvcBuilder ?? throw new ArgumentNullException(nameof(mvcBuilder));
             _intermediateProvider = services.BuildServiceProvider();
             var loggerFactory = _intermediateProvider.GetService<ILoggerFactory>();
             _resourceGraphBuilder = new ResourceGraphBuilder(_options, loggerFactory);

src/JsonApiDotNetCore/Configuration/ResourceGraphBuilder.cs

@@ -17,7 +17,7 @@ public class ResourceGraphBuilder
 
         public ResourceGraphBuilder(IJsonApiOptions options, ILoggerFactory loggerFactory)
         {
-            _options = options;
+            _options = options ?? throw new ArgumentNullException(nameof(options));
             _logger = loggerFactory?.CreateLogger<ResourceGraphBuilder>();
         }
 

src/JsonApiDotNetCore/Configuration/ServiceDiscoveryFacade.cs

@@ -54,8 +54,8 @@ public class ServiceDiscoveryFacade
 
         public ServiceDiscoveryFacade(IServiceCollection services, ResourceGraphBuilder resourceGraphBuilder, ILoggerFactory loggerFactory)
         {
-            _services = services;
-            _resourceGraphBuilder = resourceGraphBuilder;
+            _services = services ?? throw new ArgumentNullException(nameof(services));
+            _resourceGraphBuilder = resourceGraphBuilder ?? throw new ArgumentNullException(nameof(resourceGraphBuilder));
             _logger = loggerFactory?.CreateLogger<ResourceGraphBuilder>();
         }
 

src/JsonApiDotNetCore/Middleware/IQueryStringActionFilter.cs

@@ -3,7 +3,7 @@
 namespace JsonApiDotNetCore.Middleware
 {
     /// <summary>
-    /// Entry point for processing all query string parameters.
+    /// Extensibility point for processing request query strings.
     /// </summary>
     public interface IQueryStringActionFilter : IActionFilter { }
 }

src/JsonApiDotNetCore/Middleware/JsonApiExceptionFilter.cs

@@ -23,7 +23,7 @@ public void OnException(ExceptionContext context)
                 throw new ArgumentNullException(nameof(context));
             }
 
-            if (context.HttpContext.IsJsonApiRequest())
+            if (!context.HttpContext.IsJsonApiRequest())
             {
                 return;
             }

src/JsonApiDotNetCore/Middleware/JsonApiRoutingConvention.cs

@@ -39,8 +39,8 @@ public class JsonApiRoutingConvention : IJsonApiRoutingConvention
 
         public JsonApiRoutingConvention(IJsonApiOptions options, IResourceGraph resourceGraph)
         {
-            _options = options;
-            _resourceGraph = resourceGraph;
+            _options = options ?? throw new ArgumentNullException(nameof(options));
+            _resourceGraph = resourceGraph ?? throw new ArgumentNullException(nameof(resourceGraph));
         }
 
         /// <inheritdoc />
@@ -73,7 +73,7 @@ public void Apply(ApplicationModel application)
                     }
                 }
 
-                if (RoutingConventionDisabled(controller) == false)
+                if (!RoutingConventionDisabled(controller))
                 {
                     continue;
                 }
@@ -85,7 +85,7 @@ public void Apply(ApplicationModel application)
                         $"Controllers with overlapping route templates detected: {controller.ControllerType.FullName}");
                 }
 
-                controller.Selectors[0].AttributeRouteModel = new AttributeRouteModel {Template = template};
+                controller.Selectors[0].AttributeRouteModel = new AttributeRouteModel { Template = template };
             }
         }