Refactoring based as per code review suggestions

Author: lheiskan

src/JsonApiDotNetCore/Builders/DocumentBuilder.cs

@@ -13,14 +13,14 @@ public class DocumentBuilder : IDocumentBuilder
         private readonly IJsonApiContext _jsonApiContext;
         private readonly IContextGraph _contextGraph;
         private readonly IRequestMeta _requestMeta;
-        private readonly DocumentBuilderOptions _documentBuilderOptions = new DocumentBuilderOptions();
+        private readonly DocumentBuilderOptions _documentBuilderOptions; 
 
-        public DocumentBuilder(IJsonApiContext jsonApiContext, IRequestMeta requestMeta=null, IDocumentBuilderBehavior documentBuilderBehavior=null)
+        public DocumentBuilder(IJsonApiContext jsonApiContext, IRequestMeta requestMeta=null, IDocumentBuilderOptionsProvider documentBuilderOptionsProvider=null)
         {
             _jsonApiContext = jsonApiContext;
             _contextGraph = jsonApiContext.ContextGraph;
             _requestMeta = requestMeta;
-            _documentBuilderOptions = documentBuilderBehavior?.GetDocumentBuilderOptions() ?? _documentBuilderOptions;
+            _documentBuilderOptions = documentBuilderOptionsProvider?.GetDocumentBuilderOptions() ?? new DocumentBuilderOptions(); ;
         }
 
         public Document Build(IIdentifiable entity)

src/JsonApiDotNetCore/Builders/DocumentBuilderBehavior.cs renamed to src/JsonApiDotNetCore/Builders/DocumentBuilderOptionsProvider.cs

@@ -6,15 +6,15 @@
 
 namespace JsonApiDotNetCore.Builders
 {
-    public class DocumentBuilderBehavior : IDocumentBuilderBehavior
+    public class DocumentBuilderOptionsProvider : IDocumentBuilderOptionsProvider
     {
         private readonly IJsonApiContext _jsonApiContext;
         private readonly IHttpContextAccessor _httpContextAccessor;
 
-        public DocumentBuilderBehavior(IJsonApiContext jsonApiContext, IHttpContextAccessor httpContextAccessor)
+        public DocumentBuilderOptionsProvider(IJsonApiContext jsonApiContext, IHttpContextAccessor httpContextAccessor)
         {
-            this._jsonApiContext = jsonApiContext;
-            this._httpContextAccessor = httpContextAccessor;
+            _jsonApiContext = jsonApiContext;
+            _httpContextAccessor = httpContextAccessor;
         }
 
         public DocumentBuilderOptions GetDocumentBuilderOptions()

src/JsonApiDotNetCore/Builders/IDocumentBuilderBehavior.cs renamed to src/JsonApiDotNetCore/Builders/IDocumentBuilderOptionsProvider.cs

@@ -4,7 +4,7 @@
 
 namespace JsonApiDotNetCore.Builders
 {
-    public interface IDocumentBuilderBehavior
+    public interface IDocumentBuilderOptionsProvider
     {
         DocumentBuilderOptions GetDocumentBuilderOptions(); 
     }

src/JsonApiDotNetCore/Extensions/IServiceCollectionExtensions.cs

@@ -112,7 +112,7 @@ public static void AddJsonApiInternals(
             services.AddScoped<IQueryAccessor, QueryAccessor>();
             services.AddScoped<IQueryParser, QueryParser>();
             services.AddScoped<IControllerContext, Services.ControllerContext>();
-            services.AddScoped<IDocumentBuilderBehavior, DocumentBuilderBehavior>();
+            services.AddScoped<IDocumentBuilderOptionsProvider, DocumentBuilderOptionsProvider>();
         }
 
         public static void SerializeAsJsonApi(this MvcOptions options, JsonApiOptions jsonApiOptions)

test/UnitTests/Builders/DocumentBuilderBehaviour_Tests.cs

@@ -63,7 +63,7 @@ public void CheckNullBehaviorCombination(bool? omitNullValuedAttributes, bool? a
             var httpContextAccessorMock = new Mock<IHttpContextAccessor>();
             httpContextAccessorMock.SetupGet(m => m.HttpContext).Returns(httpContext);
 
-            var sut = new DocumentBuilderBehavior(jsonApiContextMock.Object, httpContextAccessorMock.Object);
+            var sut = new DocumentBuilderOptionsProvider(jsonApiContextMock.Object, httpContextAccessorMock.Object);
             var documentBuilderOptions = sut.GetDocumentBuilderOptions();
 
             Assert.Equal(omitsNulls, documentBuilderOptions.OmitNullValuedAttributes);

test/UnitTests/Builders/DocumentBuilder_Tests.cs

@@ -155,7 +155,7 @@ public void DocumentBuilderOptions(bool? omitNullValuedAttributes,
             string attributeValue,
             bool resultContainsAttribute)
         {
-            var documentBuilderBehaviourMock = new Mock<IDocumentBuilderBehavior>();
+            var documentBuilderBehaviourMock = new Mock<IDocumentBuilderOptionsProvider>();
             if (omitNullValuedAttributes.HasValue)
             {
                 documentBuilderBehaviourMock.Setup(m => m.GetDocumentBuilderOptions())