Enhanced rendering of error.source.pointer on ModelState validation errors

Author: Bart Koelman

CSharpGuidelinesAnalyzer.config

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <cSharpGuidelinesAnalyzerSettings>
   <setting rule="AV1561" name="MaxParameterCount" value="6" />
-  <setting rule="AV1561" name="MaxConstructorParameterCount" value="12" />
+  <setting rule="AV1561" name="MaxConstructorParameterCount" value="13" />
 </cSharpGuidelinesAnalyzerSettings>

docs/getting-started/step-by-step.md

@@ -69,9 +69,9 @@ where `TResource` is the model that inherits from `Identifiable<TId>`.
 ```c#
 public class PeopleController : JsonApiController<Person, int>
 {
-    public PeopleController(IJsonApiOptions options, ILoggerFactory loggerFactory,
-        IResourceService<Person, int> resourceService)
-        : base(options, loggerFactory, resourceService)
+    public PeopleController(IJsonApiOptions options, IResourceGraph resourceGraph,
+        ILoggerFactory loggerFactory, IResourceService<Person, int> resourceService)
+        : base(options, resourceGraph, loggerFactory, resourceService)
     {
     }
 }

docs/usage/extensibility/controllers.md

@@ -5,9 +5,9 @@ You need to create controllers that inherit from `JsonApiController<TResource, T
 ```c#
 public class ArticlesController : JsonApiController<Article, Guid>
 {
-    public ArticlesController(IJsonApiOptions options, ILoggerFactory loggerFactory,
-        IResourceService<Article, Guid> resourceService)
-        : base(options, loggerFactory, resourceService)
+    public ArticlesController(IJsonApiOptions options, IResourceGraph resourceGraph,
+        ILoggerFactory loggerFactory, IResourceService<Article, Guid> resourceService)
+        : base(options, resourceGraph, loggerFactory, resourceService)
     {
     }
 }
@@ -24,9 +24,9 @@ This approach is ok, but introduces some boilerplate that can easily be avoided.
 ```c#
 public class ArticlesController : BaseJsonApiController<Article, int>
 {
-    public ArticlesController(IJsonApiOptions options, ILoggerFactory loggerFactory,
-        IResourceService<Article, int> resourceService)
-        : base(options, loggerFactory, resourceService)
+    public ArticlesController(IJsonApiOptions options, IResourceGraph resourceGraph,
+        ILoggerFactory loggerFactory, IResourceService<Article, int> resourceService)
+        : base(options, resourceGraph, loggerFactory, resourceService)
     {
     }
 
@@ -61,9 +61,9 @@ An attempt to use one of the blacklisted methods will result in a HTTP 405 Metho
 [HttpReadOnly]
 public class ArticlesController : BaseJsonApiController<Article, int>
 {
-    public ArticlesController(IJsonApiOptions options, ILoggerFactory loggerFactory,
-        IResourceService<Article, int> resourceService)
-        : base(options, loggerFactory, resourceService)
+    public ArticlesController(IJsonApiOptions options, IResourceGraph resourceGraph,
+        ILoggerFactory loggerFactory, IResourceService<Article, int> resourceService)
+        : base(options, resourceGraph, loggerFactory, resourceService)
     {
     }
 }
@@ -80,9 +80,9 @@ For more information about resource service injection, see [Replacing injected s
 ```c#
 public class ReportsController : BaseJsonApiController<Report, int>
 {
-    public ReportsController(IJsonApiOptions options, ILoggerFactory loggerFactory,
-        IGetAllService<Report, int> getAllService)
-        : base(options, loggerFactory, getAllService)
+    public ReportsController(IJsonApiOptions options, IResourceGraph resourceGraph,
+        ILoggerFactory loggerFactory, IGetAllService<Report, int> getAllService)
+        : base(options, resourceGraph, loggerFactory, getAllService)
     {
     }
 

docs/usage/extensibility/services.md

@@ -156,9 +156,10 @@ Then in the controller, you should inherit from the base controller and pass the
 ```c#
 public class ArticlesController : BaseJsonApiController<Article, int>
 {
-    public ArticlesController(IJsonApiOptions options, ILoggerFactory loggerFactory,
-        ICreateService<Article, int> create, IDeleteService<Article, int> delete)
-        : base(options, loggerFactory, create: create, delete: delete)
+    public ArticlesController(IJsonApiOptions options, IResourceGraph resourceGraph,
+        ILoggerFactory loggerFactory, ICreateService<Article, int> create,
+        IDeleteService<Article, int> delete)
+        : base(options, resourceGraph, loggerFactory, create: create, delete: delete)
     {
     }
 

docs/usage/routing.md

@@ -29,9 +29,9 @@ public class OrderLine : Identifiable<int>
 
 public class OrderLineController : JsonApiController<OrderLine, int>
 {
-    public OrderLineController(IJsonApiOptions options, ILoggerFactory loggerFactory,
-        IResourceService<OrderLine, int> resourceService)
-        : base(options, loggerFactory, resourceService)
+    public OrderLineController(IJsonApiOptions options, IResourceGraph resourceGraph,
+        ILoggerFactory loggerFactory, IResourceService<OrderLine, int> resourceService)
+        : base(options, resourceGraph, loggerFactory, resourceService)
     {
     }
 }
@@ -65,9 +65,9 @@ It is possible to bypass the default routing convention for a controller.
 [Route("v1/custom/route/lines-in-order"), DisableRoutingConvention]
 public class OrderLineController : JsonApiController<OrderLine, int>
 {
-    public OrderLineController(IJsonApiOptions options, ILoggerFactory loggerFactory,
-        IResourceService<OrderLine, int> resourceService)
-        : base(options, loggerFactory, resourceService)
+    public OrderLineController(IJsonApiOptions options, IResourceGraph resourceGraph,
+        ILoggerFactory loggerFactory, IResourceService<OrderLine, int> resourceService)
+        : base(options, resourceGraph, loggerFactory, resourceService)
     {
     }
 }

docs/usage/writing/bulk-batch-operations.md

@@ -17,10 +17,10 @@ To enable operations, add a controller to your project that inherits from `JsonA
 ```c#
 public sealed class OperationsController : JsonApiOperationsController
 {
-    public OperationsController(IJsonApiOptions options, ILoggerFactory loggerFactory,
-        IOperationsProcessor processor, IJsonApiRequest request,
-        ITargetedFields targetedFields)
-        : base(options, loggerFactory, processor, request, targetedFields)
+    public OperationsController(IJsonApiOptions options, IResourceGraph resourceGraph,
+        ILoggerFactory loggerFactory, IOperationsProcessor processor,
+        IJsonApiRequest request, ITargetedFields targetedFields)
+        : base(options, resourceGraph, loggerFactory, processor, request, targetedFields)
     {
     }
 }

src/Examples/GettingStarted/Controllers/BooksController.cs

@@ -8,8 +8,8 @@ namespace GettingStarted.Controllers
 {
     public sealed class BooksController : JsonApiController<Book, int>
     {
-        public BooksController(IJsonApiOptions options, ILoggerFactory loggerFactory, IResourceService<Book, int> resourceService)
-            : base(options, loggerFactory, resourceService)
+        public BooksController(IJsonApiOptions options, IResourceGraph resourceGraph, ILoggerFactory loggerFactory, IResourceService<Book, int> resourceService)
+            : base(options, resourceGraph, loggerFactory, resourceService)
         {
         }
     }

src/Examples/GettingStarted/Controllers/PeopleController.cs

@@ -8,8 +8,8 @@ namespace GettingStarted.Controllers
 {
     public sealed class PeopleController : JsonApiController<Person, int>
     {
-        public PeopleController(IJsonApiOptions options, ILoggerFactory loggerFactory, IResourceService<Person, int> resourceService)
-            : base(options, loggerFactory, resourceService)
+        public PeopleController(IJsonApiOptions options, IResourceGraph resourceGraph, ILoggerFactory loggerFactory, IResourceService<Person, int> resourceService)
+            : base(options, resourceGraph, loggerFactory, resourceService)
         {
         }
     }

src/Examples/JsonApiDotNetCoreExample/Controllers/OperationsController.cs

@@ -9,9 +9,9 @@ namespace JsonApiDotNetCoreExample.Controllers
 {
     public sealed class OperationsController : JsonApiOperationsController
     {
-        public OperationsController(IJsonApiOptions options, ILoggerFactory loggerFactory, IOperationsProcessor processor, IJsonApiRequest request,
+        public OperationsController(IJsonApiOptions options, IResourceGraph resourceGraph, ILoggerFactory loggerFactory, IOperationsProcessor processor, IJsonApiRequest request,
             ITargetedFields targetedFields)
-            : base(options, loggerFactory, processor, request, targetedFields)
+            : base(options, resourceGraph, loggerFactory, processor, request, targetedFields)
         {
         }
     }

src/Examples/JsonApiDotNetCoreExample/Controllers/PeopleController.cs

@@ -8,8 +8,8 @@ namespace JsonApiDotNetCoreExample.Controllers
 {
     public sealed class PeopleController : JsonApiController<Person, int>
     {
-        public PeopleController(IJsonApiOptions options, ILoggerFactory loggerFactory, IResourceService<Person, int> resourceService)
-            : base(options, loggerFactory, resourceService)
+        public PeopleController(IJsonApiOptions options, IResourceGraph resourceGraph, ILoggerFactory loggerFactory, IResourceService<Person, int> resourceService)
+            : base(options, resourceGraph, loggerFactory, resourceService)
         {
         }
     }