Manually perform JADNC Full Cleanup

Author: ThomasBarnekow

src/JsonApiDotNetCore/Configuration/NoSqlServiceCollectionExtensions.cs

@@ -12,32 +12,39 @@
 namespace JsonApiDotNetCore.Configuration
 {
     /// <summary>
-    /// Provides extension methods for the registration of services and other injectables
-    /// with the service container.
+    /// Provides extension methods for the registration of services and other injectables with the service container.
     /// </summary>
     [PublicAPI]
     public static class NoSqlServiceCollectionExtensions
     {
         /// <summary>
-        /// For each resource annotated with the <see cref="NoSqlResourceAttribute" />, adds a
-        /// scoped service with a service type of <see cref="IResourceService{TResource, TId}" />
-        /// and an implementation type of <see cref="NoSqlResourceService{TResource,TId}" />.
+        /// For each resource annotated with the <see cref="NoSqlResourceAttribute" />, adds a scoped service with a service type of
+        /// <see cref="IResourceService{TResource,TId}" /> and an implementation type of <see cref="NoSqlResourceService{TResource,TId}" />.
         /// </summary>
-        /// <param name="services">The <see cref="IServiceCollection" />.</param>
-        /// <returns>The <see cref="IServiceCollection" />.</returns>
+        /// <param name="services">
+        /// The <see cref="IServiceCollection" />.
+        /// </param>
+        /// <returns>
+        /// The <see cref="IServiceCollection" />.
+        /// </returns>
         public static IServiceCollection AddNoSqlResourceServices(this IServiceCollection services)
         {
             return services.AddNoSqlResourceServices(Assembly.GetCallingAssembly());
         }
 
         /// <summary>
-        /// For each resource annotated with the <see cref="NoSqlResourceAttribute" />, adds a
-        /// scoped service with a service type of <see cref="IResourceService{TResource, TId}" />
-        /// and an implementation type of <see cref="NoSqlResourceService{TResource,TId}" />.
+        /// For each resource annotated with the <see cref="NoSqlResourceAttribute" />, adds a scoped service with a service type of
+        /// <see cref="IResourceService{TResource, TId}" /> and an implementation type of <see cref="NoSqlResourceService{TResource,TId}" />.
         /// </summary>
-        /// <param name="services">The <see cref="IServiceCollection" />.</param>
-        /// <param name="assembly">The <see cref="Assembly" /> containing the annotated resources.</param>
-        /// <returns>The <see cref="IServiceCollection" />.</returns>
+        /// <param name="services">
+        /// The <see cref="IServiceCollection" />.
+        /// </param>
+        /// <param name="assembly">
+        /// The <see cref="Assembly" /> containing the annotated resources.
+        /// </param>
+        /// <returns>
+        /// The <see cref="IServiceCollection" />.
+        /// </returns>
         public static IServiceCollection AddNoSqlResourceServices(this IServiceCollection services, Assembly assembly)
         {
             services.AddScoped<INoSqlQueryLayerComposer, NoSqlQueryLayerComposer>();

src/JsonApiDotNetCore/Queries/INoSqlQueryLayerComposer.cs

@@ -5,27 +5,26 @@
 namespace JsonApiDotNetCore.Queries
 {
     /// <summary>
-    /// Takes scoped expressions from <see cref="IQueryConstraintProvider" />s and transforms them.
-    /// Additionally provides specific transformations for NoSQL databases without support for joins.
+    /// Takes scoped expressions from <see cref="IQueryConstraintProvider" />s and transforms them. Additionally provides specific transformations for NoSQL
+    /// databases without support for joins.
     /// </summary>
     [PublicAPI]
     public interface INoSqlQueryLayerComposer
     {
         /// <summary>
-        /// Builds a filter from constraints, used to determine total resource count on a primary
-        /// collection endpoint.
+        /// Builds a filter from constraints, used to determine total resource count on a primary collection endpoint.
         /// </summary>
         FilterExpression? GetPrimaryFilterFromConstraintsForNoSql(ResourceType primaryResourceType);
 
         /// <summary>
-        /// Composes a <see cref="QueryLayer" /> and an <see cref="IncludeExpression" /> from the
-        /// constraints specified by the request. Used for primary resources.
+        /// Composes a <see cref="QueryLayer" /> and an <see cref="IncludeExpression" /> from the constraints specified by the request. Used for primary
+        /// resources.
         /// </summary>
         (QueryLayer QueryLayer, IncludeExpression Include) ComposeFromConstraintsForNoSql(ResourceType requestResourceType);
 
         /// <summary>
-        /// Composes a <see cref="QueryLayer" /> and an <see cref="IncludeExpression" /> from the
-        /// constraints specified by the request. Used for primary resources.
+        /// Composes a <see cref="QueryLayer" /> and an <see cref="IncludeExpression" /> from the constraints specified by the request. Used for primary
+        /// resources.
         /// </summary>
         (QueryLayer QueryLayer, IncludeExpression Include) ComposeForGetByIdWithConstraintsForNoSql<TId>(
             TId id,
@@ -40,27 +39,34 @@ QueryLayer ComposeForGetByIdForNoSql<TId>(TId id, ResourceType primaryResourceTy
             where TId : notnull;
 
         /// <summary>
-        /// Composes a <see cref="QueryLayer" /> from the constraints specified by the request
-        /// and a filter expression in the form "equals({propertyName},'{propertyValue}')".
-        /// Used for secondary or included resources.
+        /// Composes a <see cref="QueryLayer" /> from the constraints specified by the request and a filter expression in the form
+        /// "equals({propertyName},'{propertyValue}')". Used for secondary or included resources.
         /// </summary>
-        /// <param name="requestResourceType">The <see cref="ResourceType" /> of the secondary or included resource.</param>
-        /// <param name="propertyName">The name of the property of the secondary or included resource used for filtering.</param>
-        /// <param name="propertyValue">The value of the property of the secondary or included resource used for filtering.</param>
+        /// <param name="requestResourceType">
+        /// The <see cref="ResourceType" /> of the secondary or included resource.
+        /// </param>
+        /// <param name="propertyName">
+        /// The name of the property of the secondary or included resource used for filtering.
+        /// </param>
+        /// <param name="propertyValue">
+        /// The value of the property of the secondary or included resource used for filtering.
+        /// </param>
         /// <param name="isIncluded">
-        /// <see langword="true" />, if the resource is included by the request (e.g., "{url}?include={relationshipName}");
-        /// <see langword="false" />, if the resource is a secondary resource (e.g., "/{primary}/{id}/{relationshipName}").
+        /// <see langword="true" />, if the resource is included by the request (e.g., "{url}?include={relationshipName}"); <see langword="false" />, if the
+        /// resource is a secondary resource (e.g., "/{primary}/{id}/{relationshipName}").
         /// </param>
-        /// <returns>A tuple with a <see cref="QueryLayer" /> and an <see cref="IncludeExpression" />.</returns>
+        /// <returns>
+        /// A tuple with a <see cref="QueryLayer" /> and an <see cref="IncludeExpression" />.
+        /// </returns>
         (QueryLayer QueryLayer, IncludeExpression Include) ComposeFromConstraintsForNoSql(
             ResourceType requestResourceType,
             string propertyName,
             string propertyValue,
             bool isIncluded);
 
         /// <summary>
-        /// Builds a query that retrieves the primary resource, including all of its attributes
-        /// and all targeted relationships, during a create/update/delete request.
+        /// Builds a query that retrieves the primary resource, including all of its attributes and all targeted relationships, during a create/update/delete
+        /// request.
         /// </summary>
         (QueryLayer QueryLayer, IncludeExpression Include) ComposeForUpdateForNoSql<TId>(TId id, ResourceType primaryResourceType)
             where TId : notnull;

src/JsonApiDotNetCore/Queries/NoSqlQueryLayerComposer.cs

@@ -17,8 +17,7 @@ namespace JsonApiDotNetCore.Queries
     /// Default implementation of the <see cref="INoSqlQueryLayerComposer" />.
     /// </summary>
     /// <remarks>
-    /// Register <see cref="NoSqlQueryLayerComposer"/> with the service container as
-    /// shown in the following example.
+    /// Register <see cref="NoSqlQueryLayerComposer" /> with the service container as shown in the following example.
     /// </remarks>
     /// <example>
     /// <code><![CDATA[

src/JsonApiDotNetCore/Resources/Annotations/NoSqlHasForeignKeyAttribute.cs

@@ -30,22 +30,20 @@ namespace JsonApiDotNetCore.Resources.Annotations
     [AttributeUsage(AttributeTargets.Property)]
     public class NoSqlHasForeignKeyAttribute : Attribute
     {
-        public NoSqlHasForeignKeyAttribute(string propertyName)
-        {
-            PropertyName = propertyName;
-        }
-
         /// <summary>
-        /// Gets the name of the foreign key property corresponding to the annotated
-        /// navigation property.
+        /// Gets the name of the foreign key property corresponding to the annotated navigation property.
         /// </summary>
         public string PropertyName { get; private set; }
 
         /// <summary>
-        /// Gets or sets a value indicating whether the navigation property is on
-        /// the dependent side of the foreign key relationship. The default is
+        /// Gets or sets a value indicating whether the navigation property is on the dependent side of the foreign key relationship. The default is
         /// <see langword="true" />.
         /// </summary>
         public bool IsDependent { get; set; } = true;
+
+        public NoSqlHasForeignKeyAttribute(string propertyName)
+        {
+            PropertyName = propertyName;
+        }
     }
 }

src/JsonApiDotNetCore/Resources/Annotations/NoSqlOwnsManyAttribute.cs

@@ -4,19 +4,14 @@
 namespace JsonApiDotNetCore.Resources.Annotations
 {
     /// <summary>
-    /// Used to provide additional information for a JSON:API relationship
-    /// (https://jsonapi.org/format/#document-resource-object-relationships).
+    /// Used to provide additional information for a JSON:API relationship (https://jsonapi.org/format/#document-resource-object-relationships).
     /// </summary>
     /// <remarks>
-    /// With Cosmos DB, for example, an entity can own one or many other entity types.
-    /// In the example below, an Author entity owns many Article entities, which is also
-    /// reflected in the Entity Framework Core model. This means that all owned Article
-    /// entities will be returned with the Author. To represent Article entities as a
-    /// to-many relationship, the [HasMany] and [NoSqlOwnsMany] annotations can be combined
-    /// to indicate to the NoSQL resource service that those Article resources do not have
-    /// to be fetched. To include the Article resources into the response, the request will
-    /// have to add an include expression such as "?include=articles". Otherwise, the
-    /// Article resources will not be returned.
+    /// With Cosmos DB, for example, an entity can own one or many other entity types. In the example below, an Author entity owns many Article entities,
+    /// which is also reflected in the Entity Framework Core model. This means that all owned Article entities will be returned with the Author. To represent
+    /// Article entities as a to-many relationship, the [HasMany] and [NoSqlOwnsMany] annotations can be combined to indicate to the NoSQL resource service
+    /// that those Article resources do not have to be fetched. To include the Article resources into the response, the request will have to add an include
+    /// expression such as "?include=articles". Otherwise, the Article resources will not be returned.
     /// </remarks>
     /// <example>
     /// <code><![CDATA[

src/JsonApiDotNetCore/Resources/Annotations/NoSqlResourceAttribute.cs

@@ -9,8 +9,8 @@ namespace JsonApiDotNetCore.Resources.Annotations
     /// <summary>
     /// When put on a resource class, marks that resource as being hosted in a NoSQL database.
     /// </summary>
-    /// <seealso cref="NoSqlServiceCollectionExtensions.AddNoSqlResourceServices(IServiceCollection)"/>
-    /// <seealso cref="NoSqlServiceCollectionExtensions.AddNoSqlResourceServices(IServiceCollection, Assembly)"/>
+    /// <seealso cref="NoSqlServiceCollectionExtensions.AddNoSqlResourceServices(IServiceCollection)" />
+    /// <seealso cref="NoSqlServiceCollectionExtensions.AddNoSqlResourceServices(IServiceCollection, Assembly)" />
     [PublicAPI]
     [AttributeUsage(AttributeTargets.Class | AttributeTargets.Struct | AttributeTargets.Interface)]
     public class NoSqlResourceAttribute : Attribute