Remove redundant ApiResponse.TranslateAsync calls

Author: bkoelman

test/OpenApiNSwagEndToEndTests/Headers/ETagTests.cs

@@ -42,7 +42,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         var apiClient = new HeadersClient(httpClient);
 
         // Act
-        ApiResponse response = await ApiResponse.TranslateAsync(async () => await apiClient.HeadCountryCollectionAsync());
+        ApiResponse response = await apiClient.HeadCountryCollectionAsync();
 
         // Assert
         response.StatusCode.Should().Be((int)HttpStatusCode.OK);
@@ -69,7 +69,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         var apiClient = new HeadersClient(httpClient);
 
         // Act
-        ApiResponse<CountryCollectionResponseDocument?> response = await ApiResponse.TranslateAsync(async () => await apiClient.GetCountryCollectionAsync());
+        ApiResponse<CountryCollectionResponseDocument> response = await apiClient.GetCountryCollectionAsync();
 
         // Assert
         response.StatusCode.Should().Be((int)HttpStatusCode.OK);
@@ -91,7 +91,7 @@ public async Task Returns_no_ETag_for_failed_GET_request()
         var apiClient = new HeadersClient(httpClient);
 
         // Act
-        Func<Task> action = async () => await ApiResponse.TranslateAsync(async () => await apiClient.GetCountryAsync(unknownCountryId));
+        Func<Task> action = async () => await apiClient.GetCountryAsync(unknownCountryId);
 
         // Assert
         ApiException<ErrorResponseDocument> exception = (await action.Should().ThrowExactlyAsync<ApiException<ErrorResponseDocument>>()).Which;
@@ -154,7 +154,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         using HttpClient httpClient = _testContext.Factory.CreateDefaultClient(_logHttpMessageHandler);
         var apiClient = new HeadersClient(httpClient);
 
-        ApiResponse<CountryCollectionResponseDocument?> response1 = await ApiResponse.TranslateAsync(async () => await apiClient.GetCountryCollectionAsync());
+        ApiResponse<CountryCollectionResponseDocument> response1 = await apiClient.GetCountryCollectionAsync();
 
         string responseETag = response1.Headers[HeaderNames.ETag].Single();
 
@@ -189,8 +189,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         var apiClient = new HeadersClient(httpClient);
 
         // Act
-        ApiResponse<CountryCollectionResponseDocument?> response =
-            await ApiResponse.TranslateAsync(async () => await apiClient.GetCountryCollectionAsync(null, "\"Not-a-matching-value\""));
+        ApiResponse<CountryCollectionResponseDocument> response = await apiClient.GetCountryCollectionAsync(null, "\"Not-a-matching-value\"");
 
         // Assert
         response.StatusCode.Should().Be((int)HttpStatusCode.OK);

test/OpenApiNSwagEndToEndTests/Headers/HeaderTests.cs

@@ -76,7 +76,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         var apiClient = new HeadersClient(httpClient);
 
         // Act
-        ApiResponse response = await ApiResponse.TranslateAsync(async () => await apiClient.HeadCountryCollectionAsync());
+        ApiResponse response = await apiClient.HeadCountryCollectionAsync();
 
         // Assert
         response.StatusCode.Should().Be((int)HttpStatusCode.OK);
@@ -102,7 +102,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         var apiClient = new HeadersClient(httpClient);
 
         // Act
-        ApiResponse response = await ApiResponse.TranslateAsync(async () => await apiClient.HeadCountryAsync(existingCountry.Id));
+        ApiResponse response = await apiClient.HeadCountryAsync(existingCountry.Id);
 
         // Assert
         response.StatusCode.Should().Be((int)HttpStatusCode.OK);
@@ -129,7 +129,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         var apiClient = new HeadersClient(httpClient);
 
         // Act
-        ApiResponse response = await ApiResponse.TranslateAsync(async () => await apiClient.HeadCountryLanguagesAsync(existingCountry.Id));
+        ApiResponse response = await apiClient.HeadCountryLanguagesAsync(existingCountry.Id);
 
         // Assert
         response.StatusCode.Should().Be((int)HttpStatusCode.OK);
@@ -156,7 +156,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         var apiClient = new HeadersClient(httpClient);
 
         // Act
-        ApiResponse response = await ApiResponse.TranslateAsync(async () => await apiClient.HeadCountryLanguagesRelationshipAsync(existingCountry.Id));
+        ApiResponse response = await apiClient.HeadCountryLanguagesRelationshipAsync(existingCountry.Id);
 
         // Assert
         response.StatusCode.Should().Be((int)HttpStatusCode.OK);