Fix cibuild

Author: Bart Koelman

src/JsonApiDotNetCore/ObjectExtensions.cs

@@ -21,15 +21,15 @@ public static T[] AsArray<T>(this T element)
 
         public static List<T> AsList<T>(this T element)
         {
-            return new List<T>
+            return new()
             {
                 element
             };
         }
 
         public static HashSet<T> AsHashSet<T>(this T element)
         {
-            return new HashSet<T>
+            return new()
             {
                 element
             };

src/JsonApiDotNetCore/Serialization/Building/LinkBuilder.cs

@@ -149,14 +149,7 @@ private string ChangeTopPageSize(string pageSizeParameterValue, PageSize topPage
             {
                 var topPageSizeElement = new PaginationElementQueryStringValueExpression(null, topPageSize.Value);
 
-                if (elementInTopScopeIndex != -1)
-                {
-                    elements = elements.SetItem(elementInTopScopeIndex, topPageSizeElement);
-                }
-                else
-                {
-                    elements = elements.Insert(0, topPageSizeElement);
-                }
+                elements = elementInTopScopeIndex != -1 ? elements.SetItem(elementInTopScopeIndex, topPageSizeElement) : elements.Insert(0, topPageSizeElement);
             }
             else
             {

src/JsonApiDotNetCore/Serialization/RequestDeserializer.cs

@@ -192,7 +192,7 @@ private OperationContainer ParseForCreateOrUpdateResourceOperation(AtomicOperati
 
                 ResourceContext resourceContextInRef = GetExistingResourceContext(operation.Ref.Type);
 
-                if (resourceContextInRef != primaryResourceContext)
+                if (!primaryResourceContext.Equals(resourceContextInRef))
                 {
                     throw new JsonApiSerializationException("Resource type mismatch between 'ref.type' and 'data.type' element.",
                         $"Expected resource of type '{resourceContextInRef.PublicName}' in 'data.type', instead of '{primaryResourceContext.PublicName}'.",

test/JsonApiDotNetCoreExampleTests/IntegrationTests/Archiving/TelevisionBroadcastDefinition.cs

@@ -64,7 +64,7 @@ private bool IsRequestingCollectionOfTelevisionBroadcasts()
         {
             if (_request.IsCollection)
             {
-                if (_request.PrimaryResource == ResourceContext || _request.SecondaryResource == ResourceContext)
+                if (ResourceContext.Equals(_request.PrimaryResource) || ResourceContext.Equals(_request.SecondaryResource))
                 {
                     return true;
                 }

test/JsonApiDotNetCoreExampleTests/IntegrationTests/RestrictedControllers/SkipCacheQueryStringParameterReader.cs

@@ -1,4 +1,3 @@
-using System.Linq;
 using JetBrains.Annotations;
 using JsonApiDotNetCore.Controllers.Annotations;
 using JsonApiDotNetCore.Errors;