Skip to content

Commit 0077d15

Browse files
committed
[Xamarin.Android.Bcl-Tests] Run only in Debug configuration
Commit d1d9820 enabled `Xamarin.Android.Bcl-Tests` to build and run in the Release configuration. This was the right idea, but the wrong time: [The Jenkins build for xamarin-android/d0d8640b][xad0] reports 68 failures, due to running the `Xamarin.Android.Bcl-Tests` in the Release configuration, in which the linker is *enabled*. [xad0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/666/ Enabling the linker is breaking these tests. :-( This needs to be addressed -- enabling the linker should *not* break the BCL unit tests! -- but in the meantime, partially revert commit d1d9820 and only run the BCL unit tests in the Debug configuration, removing this source of unit test failures.
1 parent d0d8640 commit 0077d15

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ TEST_APK_PROJECTS = \
161161

162162
TEST_APK_PROJECTS_RELEASE = \
163163
src/Mono.Android/Test/Mono.Android-Tests.csproj \
164-
tests/Xamarin.Android.Bcl-Tests/Xamarin.Android.Bcl-Tests.csproj \
165164
tests/Xamarin.Forms-Performance-Integration/Droid/Xamarin.Forms.Performance.Integration.Droid.csproj
166165

167166
# Syntax: $(call BUILD_TEST_APK,path/to/project.csproj,additional_msbuild_flags)

tests/RunApkTests.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
`$(TEST_APK_PROJECTS_RELEASE)` within the toplevel `Makefile`.
2020
-->
2121
<Import Project="..\src\Mono.Android\Test\Mono.Android-Tests.projitems" />
22-
<Import Project="..\tests\Xamarin.Android.Bcl-Tests\Xamarin.Android.Bcl-Tests.projitems" />
22+
<Import Project="..\tests\Xamarin.Android.Bcl-Tests\Xamarin.Android.Bcl-Tests.projitems" Condition=" '$(Configuration)' == 'Debug' " />
2323
<Import Project="..\tests\CodeGen-Binding\Xamarin.Android.JcwGen-Tests\Xamarin.Android.JcwGen-Tests.projitems" Condition=" '$(Configuration)' == 'Debug' " />
2424
<Import Project="..\tests\locales\Xamarin.Android.Locale-Tests\Xamarin.Android.Locale-Tests.projitems" Condition=" '$(Configuration)' == 'Debug' " />
2525
<Import Project="..\tests\Xamarin.Forms-Performance-Integration\Droid\Xamarin.Forms.Performance.Integration.Droid.projitems" Condition=" '$(Configuration)' == 'Release' And '$(AotAssemblies)' != 'true' " />

0 commit comments

Comments
 (0)