You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Xamarin.Android.Cecil] fix assembly names if using $(CecilSourceDirectory)
Context: dotnet/android#1747
Downstream in xamarin-android, I started getting a build failure on
Windows such as:
xamarin-android\external\Java.Interop\src\Xamarin.Android.Cecil\Xamarin.Android.Cecil.targets(23,5): error MSB3375: The file "..\..\bin\Debug\\Xamarin.Android.Cecil.dll" does not exist.
xamarin-android\external\Java.Interop\src\Xamarin.Android.Cecil\Xamarin.Android.Cecil.targets(23,5): error MSB3375: The file "..\..\bin\Debug\\Xamarin.Android.Cecil.Mdb.dll" does not exist.
Looking in my `external\Java.Interop\bin\Debug` directory, the
`Mono.Cecil` assemblies were named `Mono.Cecil.*` instead of
`Xamarin.Android.*`.
I think this was an oversight, but I don't know how the builds were
green...
Looking at `Mono.Cecil.csproj` in
`xamarin-android/external/mono/external/cecil` there was no way to
override `AssemblyName`. But we can use the `<Move />` task instead.
To fix this:
- Added a `_MonoCecilAssemblies` to check for any files named
`Mono.Cecil.*`
- `<Move />` the files to start with `Xamarin.Android.*` instead.
0 commit comments